December 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Review someone

by Stephan Eggermont

Ben wrote: > It used to be regex, but regex are slow (and far slower than just string comparison) Yes, I saw that. They are also useful. Checking if the search string contains regex characters is not slow. Only doing regex checking when they are there solves the main slowness, without losing the flexibility. Stephan

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Stephan Eggermont

I managed to break it. Open monticello, open the 30inbox type sl return backspace backspace return Still needs a nil check it seems Stephan

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Benjamin

Because even me can do shitty stuff sometimes :P Because I can also break some standards Because I can have left some commented debugging code Because a lot of other reasons :P So indeed, it bottle necks the system, but I think that the solution is not in the check-less introduction of slices, but in a more automated process where the diff is shown easily and quickly, so one can take a quick decision and then if the huge green button is pressed, a monkey push it into Pharo. We are slowly going in this direction, but it takes time :) (my favorite reason, if I push a bug in the system, I can still blame the reviewer :P) Ben On 06 Dec 2013, at 12:04, Sven Van Caekenberghe <sven(a)stfx.eu> wrote: > > On 06 Dec 2013, at 10:38, Benjamin <benjamin.vanryseghem.pharo(a)gmail.com> wrote: > >> Hi guys, >> >> could someone have a look at this issue ? >> https://pharo.fogbugz.com/default.asp?12304 > > I do not really understand why a contribution from you that passes validation needs another extra approval. I mean, you commit stuff all the time, dangerous stuff (spec, etc..) that can break everything. And you fix the problems that accidentally introduce. > > It slows down the whole process for little quality gain. > > And the more slices get stale, the more work for the original contributor. > >> Itâs pretty simple, but I am facing the MC filter slowness 200 times per day, >> so if someone review it, then we can put it into Pharo, and make the world a better place to live. >> >> >> So if you want in a coupe of minutes makes me happy, and a better world for you children, you know what to do :) >> >> Ben >> > >

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Benjamin

On 06 Dec 2013, at 12:06, Stephan Eggermont <stephan(a)stack.nl> wrote: > Just tried in 30624. > Looks good to me. Works a lot faster. > Is not trivial to load by hand, it needs search strings entered (nil isnât empty) > The way the search is forked doesnât interfere with the UI thread? Not really, you may have some glitches if your key repetition is very low, but this can also be fixed later on if itâs a real problem > > Stephan

Dec. 6, 2013

Re: [Pharo-dev] help about codeImporter

by Stephan Eggermont

Ben wrote: >who put a Ã´ in the code at the first place ? :P Doesnât happen often, Iâm happy to observe. Strings in code with interesting characters are a much more common problem, though. Made it impossible to import MCs into Gemstone. Stephan

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Benjamin

It used to be regex, but regex are slow (and far slower than just string comparison) Ben On 06 Dec 2013, at 12:20, Stephan Eggermont <stephan(a)stack.nl> wrote: > Would it make sense to check the search string for complex strings (*\?) and switch to > regex searching then? That should be a simple extension (later). > > Stephan > > >

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Stephan Eggermont

Would it make sense to check the search string for complex strings (*\?) and switch to regex searching then? That should be a simple extension (later). Stephan

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Stephan Eggermont

Just tried in 30624. Looks good to me. Works a lot faster. Is not trivial to load by hand, it needs search strings entered (nil isnât empty) The way the search is forked doesnât interfere with the UI thread? Stephan

Dec. 6, 2013

Re: [Pharo-dev] Review someone

by Sven Van Caekenberghe

On 06 Dec 2013, at 10:38, Benjamin <benjamin.vanryseghem.pharo(a)gmail.com> wrote: > Hi guys, > > could someone have a look at this issue ? > https://pharo.fogbugz.com/default.asp?12304 I do not really understand why a contribution from you that passes validation needs another extra approval. I mean, you commit stuff all the time, dangerous stuff (spec, etc..) that can break everything. And you fix the problems that accidentally introduce. It slows down the whole process for little quality gain. And the more slices get stale, the more work for the original contributor. > Itâs pretty simple, but I am facing the MC filter slowness 200 times per day, > so if someone review it, then we can put it into Pharo, and make the world a better place to live. > > > So if you want in a coupe of minutes makes me happy, and a better world for you children, you know what to do :) > > Ben >

Dec. 6, 2013

Re: [Pharo-dev] help about codeImporter

by StÃ©phane Ducasse

Some code from middle age. Still not having a coherent behavior is a problem to me. > who put a Ã´ in the code at the first place ? :P > > Ben

Dec. 6, 2013