Because even me can do shitty stuff sometimes :P Because I can also break some standards Because I can have left some commented debugging code Because a lot of other reasons :P So indeed, it bottle necks the system, but I think that the solution is not in the check-less introduction of slices, but in a more automated process where the diff is shown easily and quickly, so one can take a quick decision and then if the huge green button is pressed, a monkey push it into Pharo. We are slowly going in this direction, but it takes time :) (my favorite reason, if I push a bug in the system, I can still blame the reviewer :P) Ben On 06 Dec 2013, at 12:04, Sven Van Caekenberghe <sven@stfx.eu> wrote:
On 06 Dec 2013, at 10:38, Benjamin <benjamin.vanryseghem.pharo@gmail.com> wrote:
Hi guys,
could someone have a look at this issue ? https://pharo.fogbugz.com/default.asp?12304
I do not really understand why a contribution from you that passes validation needs another extra approval. I mean, you commit stuff all the time, dangerous stuff (spec, etc..) that can break everything. And you fix the problems that accidentally introduce.
It slows down the whole process for little quality gain.
And the more slices get stale, the more work for the original contributor.
Itâs pretty simple, but I am facing the MC filter slowness 200 times per day, so if someone review it, then we can put it into Pharo, and make the world a better place to live.
So if you want in a coupe of minutes makes me happy, and a better world for you children, you know what to do :)
Ben