November 2013 - Pharo-dev - lists.pharo.org

Re: [Pharo-dev] Commit Rights for Pharo30Inbox

by StÃ©phane Ducasse

I tried npapagna but it did not work again this bugâ¦.. SmalltalkHub is getting our way. This is five times that I tried to modify a team and I cannot. Stef On Nov 15, 2013, at 1:37 PM, Camillo Bruni <camillobruni(a)gmail.com> wrote: > hi, can I have your smalltalkhub username? > > On 2013-11-15, at 13:30, NicolÃ¡s Papagna Maldonado <nicolas.papagna(a)gmail.com> wrote: > >> Hi all, >> >> I've been working of a bug fix and I reached the point I need to commit the slice :) >> Could someone grant me commit rights in the Pharo30Inbox please? >> >> Thanks in advance, >> >> Nico PM >

Nov. 15, 2013

Re: [Pharo-dev] Commit Rights for Pharo30Inbox

by StÃ©phane Ducasse

Thanks nicolas :) Good to see you pushing Pharo. Stef On Nov 15, 2013, at 1:30 PM, NicolÃ¡s Papagna Maldonado <nicolas.papagna(a)gmail.com> wrote: > Hi all, > > I've been working of a bug fix and I reached the point I need to commit the slice :) > Could someone grant me commit rights in the Pharo30Inbox please? > > Thanks in advance, > > Nico PM

Nov. 15, 2013

Re: [Pharo-dev] [Bug] In ClassDescription>>#linesOfCode

by Roberto Minelli

In fact *after* I wrote the email I actually thought about that. IMHO we need to have a method which gave us only the LOC of the âsideâ we are interested in, i.e., there is no way to access only the LOC of the instance side and for me this is wrong. Something like actualLinesOfCode ^ self localMethods inject: 0 into: [:sum :each | sum + each linesOfCode]. and then linesOfCode "An approximate measure of lines of code. Includes comments, but excludes blank lines." | lines | lines := self actualLinesOfCode ^ self isMeta ifTrue: [lines] ifFalse: [lines + self class linesOfCode] So that one can invoke Object>>#linesOfCode and have the current behavior, or Object>>#actualLinesOfCode and have just the instance side lines of code, and Object class>>#actualLinesOfCode and get only the meta-lines of code. Cheers, R On Nov 15, 2013, at 2:30 PM, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 15 Nov 2013, at 14:18, Marcus Denker <marcus.denker(a)inria.fr> wrote: > >> >> On 15 Nov 2013, at 14:07, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: >> >>> Hi, >>> >>> I looked at the implementation of #linesOfCode of ClassDescription. It is actually wrong, a correct version should be: >>> >>> linesOfCode >>> "An approximate measure of lines of code. Includes comments, but excludes blank lines." >>> | lines | >>> >>> lines := self localMethods inject: 0 into: [:sum :each | sum + each linesOfCode]. >>> ^ self isMeta not >>> ifTrue: [lines] >>> ifFalse: [lines + self class linesOfCode] >>> >> >> indeed! >> > Hmmâ¦ not that sure after thinking about it. > > On the meta side, we just take the linesOfCode of all methods. On the instance side, we take the linesOfCode of all method *and* the > ones of the meta. > > When you call > > Object linesOfCode > > this means it takes > > linesOfCode of Instance Side + linesOfCode of class side of Object > > which seems ok. > > Marcus >

Nov. 15, 2013

Re: [Pharo-dev] A thought about backporting

by Camillo Bruni

On 2013-11-15, at 14:26, Stephan Eggermont <stephan(a)stack.nl> wrote: > btc wrote: > >OMG! I only just noticed on the "RELEASE" page [1] the linked file "Pharo2.0-win.zip" [3] >has a last-modified-date of 2013-11-13. What crack [2] are you smoking? A "released" >file with a name like "Pharo2.0-win.zip" should NEVER change its contents. NEVER! It >SHOULD always remain the same - always - to the end of time! Backports are really >important but they should be labelled as a new version "release" or just as "latest" if >regularly uploaded from the CI. > > No. Releases on the website are for humans, not for automation. They should work and have all the latest backported bugfixes. Fixed versions for automation and sysadmins have build numbers. We have this covered with files.pharo.org I agree

Nov. 15, 2013

Re: [Pharo-dev] [Bug] In ClassDescription>>#linesOfCode

by Marcus Denker

On 15 Nov 2013, at 14:18, Marcus Denker <marcus.denker(a)inria.fr> wrote: > > On 15 Nov 2013, at 14:07, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > >> Hi, >> >> I looked at the implementation of #linesOfCode of ClassDescription. It is actually wrong, a correct version should be: >> >> linesOfCode >> "An approximate measure of lines of code. Includes comments, but excludes blank lines." >> | lines | >> >> lines := self localMethods inject: 0 into: [:sum :each | sum + each linesOfCode]. >> ^ self isMeta not >> ifTrue: [lines] >> ifFalse: [lines + self class linesOfCode] >> > > indeed! > Hmmâ¦ not that sure after thinking about it. On the meta side, we just take the linesOfCode of all methods. On the instance side, we take the linesOfCode of all method *and* the ones of the meta. When you call Object linesOfCode this means it takes linesOfCode of Instance Side + linesOfCode of class side of Object which seems ok. Marcus

Nov. 15, 2013

Re: [Pharo-dev] A thought about backporting

by Stephan Eggermont

btc wrote: >OMG! I only just noticed on the "RELEASE" page [1] the linked file "Pharo2.0-win.zip" [3] >has a last-modified-date of 2013-11-13. What crack [2] are you smoking? A "released" >file with a name like "Pharo2.0-win.zip" should NEVER change its contents. NEVER! It >SHOULD always remain the same - always - to the end of time! Backports are really >important but they should be labelled as a new version "release" or just as "latest" if >regularly uploaded from the CI. No. Releases on the website are for humans, not for automation. They should work and have all the latest backported bugfixes. Fixed versions for automation and sysadmins have build numbers. We have this covered with files.pharo.org Please read Van den Hamer & Lepoeter (1996) Managing Design Data: The Five Dimensions of CAD Frameworks, Configuration Management, and Product Data Management, Proceedings of the IEEE, Vol. 84, No 1, January 1996

Nov. 15, 2013

Re: [Pharo-dev] [Bug] In ClassDescription>>#linesOfCode

by Marcus Denker

On 15 Nov 2013, at 14:07, Roberto Minelli <roberto.minelli(a)usi.ch> wrote: > Hi, > > I looked at the implementation of #linesOfCode of ClassDescription. It is actually wrong, a correct version should be: > > linesOfCode > "An approximate measure of lines of code. Includes comments, but excludes blank lines." > | lines | > > lines := self localMethods inject: 0 into: [:sum :each | sum + each linesOfCode]. > ^ self isMeta not > ifTrue: [lines] > ifFalse: [lines + self class linesOfCode] > indeed! and after fixing, Pharo3 shrinks from 444kLoc to 368KLoc :-) Marcus

Nov. 15, 2013

Re: [Pharo-dev] Convert to Athens

by Igor Stasenko

On 14 November 2013 19:47, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr>wrote: > Hi jeff > > We should rewrite the drawnOn: method as drawAthensOn: > and we should simplify the logic because often it is wellâ¦ terrible. > Now have a look at the way the tutorial Morph is done SceneView something > because it shows the logic. > I know that there is a morph to render morph in athens. > > Yes, there is AthensSceneView (read its class comment, its really easy to use) for transition , i implemented a special morph, AthensWrapMorph which wraps (as its name says) its children morphs and forces them to be rendered by athens (the child morphs will never receive #drawOn: but #drawOnAthensCanvas: instead ). Like that you can start using athens for current state of morphic and later, when whole World will be rendered by athens, you will no longer will need to use wrapper, so you will just throw it out from hierarchy without changing your existing code. > Stef > > > On Thu, Nov 14, 2013 at 5:56 PM, kilon alios <kilon.alios(a)gmail.com>wrote: > >> Athens is a vector graphics library, its not a GUI API. Athens will not >> give you buttons, menus, drop down lists and GUI elements. It will give you >> however the means to draw all those things and much more. >> > > As far as I understand it, Athens is a vector graphics library that will > eventually replace BitBlt for rendering Morphs in Pharo. For a time, there > will be some things rendered with Athens and some things rendered with > BitBlt. How do I make the transition from BitBlt rendering to Athens > rendering? > > Cheers, > > Jeff > > > -- > Jochen "Jeff" Rick, Ph.D. > http://www.je77.com/ > Skype ID: jochenrick > > > -- Best regards, Igor Stasenko.

Nov. 15, 2013

Re: [Pharo-dev] how-to-contribute points to null

by Marcus Denker

On 15 Nov 2013, at 12:11, StÃ©phane Ducasse <stephane.ducasse(a)inria.fr> wrote: > http://www.pharo-project.org/community/how-to-contribute > > point to https://pharo.fogbugz.com/default.asp?W39 > which does not exist > I added an issue tracker entry: https://pharo.fogbugz.com/f/cases/12175

Nov. 15, 2013

[Bug] In ClassDescription>>#linesOfCode

by Roberto Minelli

Hi, I looked at the implementation of #linesOfCode of ClassDescription. It is actually wrong, a correct version should be: linesOfCode "An approximate measure of lines of code. Includes comments, but excludes blank lines." | lines | lines := self localMethods inject: 0 into: [:sum :each | sum + each linesOfCode]. ^ self isMeta not ifTrue: [lines] ifFalse: [lines + self class linesOfCode] Cheers, Roby

Nov. 15, 2013