January 2010 - Pharo-dev - lists.pharo.org

[Pharo-project] [update 1.1] #11180

by Marcus Denker

11180 ----- Issue 1383: Behavior>>isAbstractClass Issue 1869: add MC package clean to ScriptLoader releaseclean script -- Marcus Denker -- http://www.marcusdenker.de INRIA Lille -- Nord Europe. Team RMoD.

Jan. 24, 2010

Re: [Pharo-project] TestIndenting fails with Exupery (was: [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2)

by Mariano Martinez Peck

Yes, that's another possibility. What I was thinking is to put them in expdetedFailures. Something like this: expectedFailures self isTrueTypePluginsInstalled ifFalse: [ ^ #( #test1 #test2 ... ) ] On Sun, Jan 24, 2010 at 6:29 PM, Adrian Lienhard <adi(a)netstyle.ch> wrote: > I think we should just delete such kind of tests that depend on custom > settings and fonts. > > Adrian > > > On Jan 24, 2010, at 15:47 , laurent laffont wrote: > > > If I delete FTPlugin directory found in Exupery vm then TestIndenting > > succeed. So FTPlugin + Exupery + Linux = TestIndenting fails. > > > > Someone know how can I compile squeak vm with FTPlugin ? I cannot find > > informations on this. > > > > Cheers. > > > > Laurent > > > > > > 2010/1/23 Mariano Martinez Peck <marianopeck(a)gmail.com> > > > >> > >> > >> 2010/1/23 laurent laffont <laurent.laffont(a)gmail.com> > >> > >>> I lack knowledge :( > >> > >> > >> me too :) Don't worry. We are all trying to do our best. > >> > >> > >>> how can I enable / disable a plugin ? > >> > >> > >> I don't know if this is possible. Maybe in some Linux/Mac distros maybe > how > >> can just delete the files, but in Windows for example, I think they are > >> build inside the vm... > >> > >> > >>> What can I check more precisely ? > >>> > >>> > >> I think with this: " SmalltalkImage current listLoadedModules" > >> > >> What would really help is to: > >> > >> - See which plugins do you have in each Linux VM, with that piece of > code. > >> > >> - Check which tests are failing and do a quick review. Because maybe > they > >> are failing due to a primitive or something for the VM. We need to > discover > >> what is the problem. Not necessary fix it, but at least to know where > the > >> problem came from. > >> > >> Cheers and thanks a lot for the help. > >> > >> Mariano > >> > >> > >> > >>> Laurent > >>> > >>> > >>> 2010/1/23 Mariano Martinez Peck <marianopeck(a)gmail.com> > >>> > >>> wow....Laurent: can you check which and why are the tests that are > failing > >>>> in each vm but not in the other ? > >>>> > >>>> maybe because of FTPlugin ? or another plugin that it is not in both > >>>> vms but requiered by the tests? > >>>> > >>>> 2010/1/23 laurent laffont <laurent.laffont(a)gmail.com> > >>>> > >>>> And with squeak vm there's less failures. > >>>>> > >>>>> Laurent Laffont > >>>>> > >>>>> > >>>>> > >>>>> On Fri, Jan 22, 2010 at 5:18 PM, laurent laffont < > >>>>> laurent.laffont(a)gmail.com> wrote: > >>>>> > >>>>>> On Linux, exupery VM > >>>>>> > >>>>>> Laurent > >>>>>> > >>>>>> 2010/1/22 Benoit St-Jean <bstjean(a)yahoo.com> > >>>>>> > >>>>>>> Here's the first test run, on a fresh image (see JPEG attached for > >>>>>>> results). > >>>>>>> > >>>>>>> > >>>>>>> I just unzipped the files, started Pharo and ran the Test Runner. > >>>>>>> > >>>>>>> No preferences changed, nothing even evaluated in a workspace! > >>>>>>> > >>>>>>> I'm on XP if that helps! > >>>>>>> > >>>>>>> > >>>>>>> _______________________________________________ > >>>>>>> Pharo-project mailing list > >>>>>>> Pharo-project(a)lists.gforge.inria.fr > >>>>>>> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >>>>>>> > >>>>>> > >>>>>> > >>>>> > >>>>> _______________________________________________ > >>>>> Pharo-project mailing list > >>>>> Pharo-project(a)lists.gforge.inria.fr > >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >>>>> > >>>> > >>>> > >>>> _______________________________________________ > >>>> Pharo-project mailing list > >>>> Pharo-project(a)lists.gforge.inria.fr > >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >>>> > >>> > >>> > >>> _______________________________________________ > >>> Pharo-project mailing list > >>> Pharo-project(a)lists.gforge.inria.fr > >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >>> > >> > >> > >> _______________________________________________ > >> Pharo-project mailing list > >> Pharo-project(a)lists.gforge.inria.fr > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >> > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 24, 2010

Re: [Pharo-project] TestIndenting fails with Exupery (was: [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2)

by Adrian Lienhard

I think we should just delete such kind of tests that depend on custom settings and fonts. Adrian On Jan 24, 2010, at 15:47 , laurent laffont wrote: > If I delete FTPlugin directory found in Exupery vm then TestIndenting > succeed. So FTPlugin + Exupery + Linux = TestIndenting fails. > > Someone know how can I compile squeak vm with FTPlugin ? I cannot find > informations on this. > > Cheers. > > Laurent > > > 2010/1/23 Mariano Martinez Peck <marianopeck(a)gmail.com> > >> >> >> 2010/1/23 laurent laffont <laurent.laffont(a)gmail.com> >> >>> I lack knowledge :( >> >> >> me too :) Don't worry. We are all trying to do our best. >> >> >>> how can I enable / disable a plugin ? >> >> >> I don't know if this is possible. Maybe in some Linux/Mac distros maybe how >> can just delete the files, but in Windows for example, I think they are >> build inside the vm... >> >> >>> What can I check more precisely ? >>> >>> >> I think with this: " SmalltalkImage current listLoadedModules" >> >> What would really help is to: >> >> - See which plugins do you have in each Linux VM, with that piece of code. >> >> - Check which tests are failing and do a quick review. Because maybe they >> are failing due to a primitive or something for the VM. We need to discover >> what is the problem. Not necessary fix it, but at least to know where the >> problem came from. >> >> Cheers and thanks a lot for the help. >> >> Mariano >> >> >> >>> Laurent >>> >>> >>> 2010/1/23 Mariano Martinez Peck <marianopeck(a)gmail.com> >>> >>> wow....Laurent: can you check which and why are the tests that are failing >>>> in each vm but not in the other ? >>>> >>>> maybe because of FTPlugin ? or another plugin that it is not in both >>>> vms but requiered by the tests? >>>> >>>> 2010/1/23 laurent laffont <laurent.laffont(a)gmail.com> >>>> >>>> And with squeak vm there's less failures. >>>>> >>>>> Laurent Laffont >>>>> >>>>> >>>>> >>>>> On Fri, Jan 22, 2010 at 5:18 PM, laurent laffont < >>>>> laurent.laffont(a)gmail.com> wrote: >>>>> >>>>>> On Linux, exupery VM >>>>>> >>>>>> Laurent >>>>>> >>>>>> 2010/1/22 Benoit St-Jean <bstjean(a)yahoo.com> >>>>>> >>>>>>> Here's the first test run, on a fresh image (see JPEG attached for >>>>>>> results). >>>>>>> >>>>>>> >>>>>>> I just unzipped the files, started Pharo and ran the Test Runner. >>>>>>> >>>>>>> No preferences changed, nothing even evaluated in a workspace! >>>>>>> >>>>>>> I'm on XP if that helps! >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Pharo-project mailing list >>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>>> >>>>>> >>>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 24, 2010

Re: [Pharo-project] TestIndenting fails with Exupery (was: [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2)

by laurent laffont

2010/1/24 Mariano Martinez Peck <marianopeck(a)gmail.com> > > > 2010/1/24 laurent laffont <laurent.laffont(a)gmail.com> > > If I delete FTPlugin directory found in Exupery vm then TestIndenting >> succeed. So FTPlugin + Exupery + Linux = TestIndenting fails. >> >> Someone know how can I compile squeak vm with FTPlugin ? I cannot find >> informations on this. >> >> > Me neither. I checked in http://www.squeakvm.org/unix/index.html > > but I didn't find anything. There is a squeakVM mailing list. Maybe it > would be better to ask there ? > > done. See http://lists.squeakfoundation.org/pipermail/vm-dev/2010-January/003747.html Laurent.

Jan. 24, 2010

Re: [Pharo-project] RBSpelling errors when class has Pool Dictionary - Re: [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2

by Lukas Renggli

>> 'IT' 'OK and 'don't' are all flagged - don't is not flagged. Is this your >> preferred behaviour? > > They are all not flagged on my machine. Neither with the internal nor > with the mac spelling. Maybe you need to delete the cached dictionary rb-spelling.dat? I had to create a new one to include all the short forms "don't", "won't", ... Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Jan. 24, 2010

Re: [Pharo-project] RBSpelling errors when class has Pool Dictionary - Re: [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2

by Lukas Renggli

> I get three fails of your 'meta' tests: > > #testIdentifier - 'Got ''$a'', but expected ''a''' > #testCamelCase - '#normalizeCamelCase: is not idempotent' Â (puts in an > extra space) 'Camel Â Case' vs 'Camel Case' > #testSelector - '#normalizeSelector: is not idempotent' Are you sure you have the latest code loaded (Refactoring-Spelling-lr.19)? Because I fixed those bugs. > also in the original tests on real classes > > RBArgumentVariableNamesSpellingClass>>argumentVariableNamesSpelling: rong > <- not flagged > Â Â Â Â ^self 'rong' is in the dictionary as a correct word thus it is correct. The tests that work on code should only test the extraction of text from code, not other things like the spell checker itself. That's why I moved such tests to a separate class (RBSpellCheckerTest). Of course you can argue that it is a bug to have 'rong' in the dictionary. Could be that this was part of some slang or abbreviations dictionary I've included. I bet nobody wants to go through this list of almost a million words and check them all? > 'IT' 'OK and 'don't' are all flagged - don't is not flagged. Is this your > preferred behaviour? They are all not flagged on my machine. Neither with the internal nor with the mac spelling. > What do you think about including the 'real' tests as well as the meta > tests? I don't like it at all. I hate the situation we currently have with Slime. We will have to fix that. People run the rules on the complete image and then they suddenly have dozens of errors that do not matter. > Real tests also have the benefit of serving as examples to people who are > trying to use tests to understand the system. And there might be a risk that > a meta test passes without testing the real live situation. These are negative examples. You don't want to show a newbie negative examples. It is also dangerous in books to show examples of how not to do it. People don't always understand/read everything and just copy and past whatever they see. After all these are not meta-examples, these are just like the real examples. Except that the code is only present in the image while the tests run. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Jan. 24, 2010

Re: [Pharo-project] TestIndenting fails with Exupery (was: [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2)

by Mariano Martinez Peck

2010/1/24 laurent laffont <laurent.laffont(a)gmail.com> > If I delete FTPlugin directory found in Exupery vm then TestIndenting > succeed. So FTPlugin + Exupery + Linux = TestIndenting fails. > > Someone know how can I compile squeak vm with FTPlugin ? I cannot find > informations on this. > > Me neither. I checked in http://www.squeakvm.org/unix/index.html but I didn't find anything. There is a squeakVM mailing list. Maybe it would be better to ask there ? Cheers Mariano > Cheers. > > Laurent > > > 2010/1/23 Mariano Martinez Peck <marianopeck(a)gmail.com> > >> >> >> 2010/1/23 laurent laffont <laurent.laffont(a)gmail.com> >> >>> I lack knowledge :( >> >> >> me too :) Don't worry. We are all trying to do our best. >> >> >>> how can I enable / disable a plugin ? >> >> >> I don't know if this is possible. Maybe in some Linux/Mac distros maybe >> how can just delete the files, but in Windows for example, I think they are >> build inside the vm... >> >> >>> What can I check more precisely ? >>> >>> >> I think with this: " SmalltalkImage current listLoadedModules" >> >> What would really help is to: >> >> - See which plugins do you have in each Linux VM, with that piece of >> code. >> - Check which tests are failing and do a quick review. Because maybe they >> are failing due to a primitive or something for the VM. We need to discover >> what is the problem. Not necessary fix it, but at least to know where the >> problem came from. >> >> Cheers and thanks a lot for the help. >> >> Mariano >> >> >> >>> Laurent >>> >>> >>> 2010/1/23 Mariano Martinez Peck <marianopeck(a)gmail.com> >>> >>> wow....Laurent: can you check which and why are the tests that are >>>> failing in each vm but not in the other ? >>>> >>>> maybe because of FTPlugin ? or another plugin that it is not in both >>>> vms but requiered by the tests? >>>> >>>> 2010/1/23 laurent laffont <laurent.laffont(a)gmail.com> >>>> >>>> And with squeak vm there's less failures. >>>>> >>>>> Laurent Laffont >>>>> >>>>> >>>>> >>>>> On Fri, Jan 22, 2010 at 5:18 PM, laurent laffont < >>>>> laurent.laffont(a)gmail.com> wrote: >>>>> >>>>>> On Linux, exupery VM >>>>>> >>>>>> Laurent >>>>>> >>>>>> 2010/1/22 Benoit St-Jean <bstjean(a)yahoo.com> >>>>>> >>>>>>> Here's the first test run, on a fresh image (see JPEG attached for >>>>>>> results). >>>>>>> >>>>>>> >>>>>>> I just unzipped the files, started Pharo and ran the Test Runner. >>>>>>> >>>>>>> No preferences changed, nothing even evaluated in a workspace! >>>>>>> >>>>>>> I'm on XP if that helps! >>>>>>> >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Pharo-project mailing list >>>>>>> Pharo-project(a)lists.gforge.inria.fr >>>>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>>>> >>>>>> >>>>>> >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 24, 2010

Re: [Pharo-project] RBSpelling errors when class has Pool Dictionary - Re: [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2

by Stan Shepherd

Lukas, I get three fails of your 'meta' tests: #testIdentifier - 'Got ''$a'', but expected ''a''' #testCamelCase - '#normalizeCamelCase: is not idempotent' (puts in an extra space) 'Camel Case' vs 'Camel Case' #testSelector - '#normalizeSelector: is not idempotent' also in the original tests on real classes RBArgumentVariableNamesSpellingClass>>argumentVariableNamesSpelling: rong <- not flagged ^self RBTemporaryVariableNamesSpellingClassSideClass>>temporaryVariableNamesSpellingClassSide | rongTemporary | <- not flagged ^self RBCorrectSpellingClass 'IT' 'OK and 'don't' are all flagged - don't is not flagged. Is this your preferred behaviour? What do you think about including the 'real' tests as well as the meta tests? Real tests also have the benefit of serving as examples to people who are trying to use tests to understand the system. And there might be a risk that a meta test passes without testing the real live situation. ...Stan -- View this message in context: http://n2.nabble.com/BetaTesting-ANN-Pharo1-0-10507-rc2dev10-01-2-tp4440307… Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Jan. 24, 2010

Re: [Pharo-project] RBSpelling errors when class has Pool Dictionary - Re: [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2

by Lukas Renggli

> I haven't such file :( True, you are on a mac too :-) Go to "Apple Mail" and type the word "Refactoring". It should be highlighted with the spell-checker. Click on "Add to Dictionary". Then the tests should pass. No, sorry. I have to fix the tests. Wait. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Jan. 24, 2010

Re: [Pharo-project] RBSpelling errors when class has Pool Dictionary - Re: [BetaTesting] [ANN] Pharo1.0-10507-rc2dev10.01.2

by Mariano Martinez Peck

On Sun, Jan 24, 2010 at 5:08 PM, Lukas Renggli <renggli(a)gmail.com> wrote: > > I attach screenshot. > > Delete the file rb-spelling.dat next to your image, that should fix the > problem. > > I haven't such file :( > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 24, 2010