January 2010 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] Spell check test cases

by Stan Shepherd

Lukas Renggli wrote: > > Hi Stan, > >> Some are failing, as there are $' characters being passed through from >> the >> parser. Also, the literals check sees to be checking the node, rather >> than >> the node value. > > You are right, the code that extracted arguments and temps > unnecessarily put the names into $' characters. This is totally wrong > and also breaks the highlighting in the browser. Instead of changing > the tokenizer (as you proposed) I fixed the places where the nodes > were collected. Like this there should be no more $' characters in the > strings that are checked. > > Name: Refactoring-Spelling-lr.10 > Author: lr > Time: 12 January 2010, 12:16:16 am > UUID: b40774a4-8371-42f4-883c-469d6fe1e020 > Ancestors: Refactoring-Spelling-lr.9 > > - fixed the bug pointed out by Stan Shepherd that temps and arguments > were not properly checked > - this also fixes the issue of not highlighting typos in temps and > arguments (which I looked into earlier today, but couldn't figure out > the real cause) > >> There are some suggested changes in the same repository, that make the >> tests >> run green, and don't appear to affect the rest of Refactoring-Tests. > > The tests are really cool. I would like to add them to the main > repository, but two are broken depending on what checker is used: > > RBMacSpellChecker: #testLiteralValues and #testPoolVariable > RBInternalSpellChecker: #testLiteralValues and #testClassComments > > Maybe that could be fixed by always using the internal one for the > tests, but then I don't understand why the tests break. Does my fix > not solve the whole problem? > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > Glad you like the tests. In my version of RBSpellChecker>>normalize, I also commented out the line: "or: [ input peek = $' ]" "this causes false positives eg 'OK' in class comments" OK returns an error on k, RB b etc. So that's what causes the two cases on a Linux box (fairly sure). I'm guessing you have letters k i b and t in the Mac dictionary, or it specifically doesn't check one letter words? As for the Mac, I didn't think of that. I'd say you have 'Smalltalk' in your Mac dictionary. I chose that as the error Pool Dictionary, to avoid polluting the system with a dictionary and risk it failing to clean up. So we could temporarily add a Pool Dictionary in setUp/tearDown, which was how I originally did it. BTW, it looks like RBPoolVariableNameSpellingRule should be RBPoolDictionaryNameSpellingRule, as that's what it looks at? Cheers, ...Stan PS just noticed that code critics browser doesn't highlight Method protocols, even though it does find the typos. Could be related, but I don't think so. -- View this message in context: http://n2.nabble.com/Spell-check-test-cases-tp4288633p4288993.html Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Jan. 12, 2010

Re: [Pharo-project] [BUG] Bitmap DejaVu Sans / WideString

by Lukas Renggli

> I'd recon so, since there's been no changes to the rendering methods since > he sent the mail. > It's kind of hard to reproduce with just a screenshot of the Text displaying > wrongly and not the text itself though :P What I thought you could do to reproduce was to print WideString allInstances in a workspace. Strangely I cannot observe it anymore in the latest Pharo 1.0rc1. Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Jan. 11, 2010

Re: [Pharo-project] Spell check test cases

by Lukas Renggli

Hi Stan, > Some are failing, as there are $' characters being passed through from the > parser. Also, the literals check sees to be checking the node, rather than > the node value. You are right, the code that extracted arguments and temps unnecessarily put the names into $' characters. This is totally wrong and also breaks the highlighting in the browser. Instead of changing the tokenizer (as you proposed) I fixed the places where the nodes were collected. Like this there should be no more $' characters in the strings that are checked. Name: Refactoring-Spelling-lr.10 Author: lr Time: 12 January 2010, 12:16:16 am UUID: b40774a4-8371-42f4-883c-469d6fe1e020 Ancestors: Refactoring-Spelling-lr.9 - fixed the bug pointed out by Stan Shepherd that temps and arguments were not properly checked - this also fixes the issue of not highlighting typos in temps and arguments (which I looked into earlier today, but couldn't figure out the real cause) > There are some suggested changes in the same repository, that make the tests > run green, and don't appear to affect the rest of Refactoring-Tests. The tests are really cool. I would like to add them to the main repository, but two are broken depending on what checker is used: RBMacSpellChecker: #testLiteralValues and #testPoolVariable RBInternalSpellChecker: #testLiteralValues and #testClassComments Maybe that could be fixed by always using the internal one for the tests, but then I don't understand why the tests break. Does my fix not solve the whole problem? Lukas -- Lukas Renggli http://www.lukas-renggli.ch

Jan. 11, 2010

Re: [Pharo-project] [BUG] Bitmap DejaVu Sans / WideString

by Henrik Sperre Johansen

I'd recon so, since there's been no changes to the rendering methods since he sent the mail. It's kind of hard to reproduce with just a screenshot of the Text displaying wrongly and not the text itself though :P Cheers, Henry On 12.01.2010 00:04, Mariano Martinez Peck wrote: > this is still present? Henrik do you know if it is the same problem > of the other thread ? > > Should we open a issue ? > > 2009/12/27 Lukas Renggli <renggli(a)gmail.com <mailto:renggli@gmail.com>> > > Bitmap DejaVu Sans displays WideStrings in unpredictable ways. > > Looks like there is a bug in StrikeFont? > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > <mailto:Pharo-project@lists.gforge.inria.fr> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > >

Jan. 11, 2010

Re: [Pharo-project] Core font

by Henrik Sperre Johansen

The fix was submitted a few months ago by Juan, and has been in VMMaker since shortly since. AFAIK, the only offical VM including it at the moment is John's beta 5.0 VM's for OSX. I've built a version to use on Windows including it, but that's more of a private intermediate solution while waiting for an official release including all the fixes that have been made since 3.11.5 :) Cheers, Henry On 12.01.2010 00:08, Mariano Martinez Peck wrote: > Henrik do you know the state of this issue with the VMs ? > > Maybe we can create an issue so that not to forget. > > cheers > > mariano > > On Wed, Nov 11, 2009 at 2:16 PM, Henrik Johansen > <henrik.s.johansen(a)veloxit.no <mailto:henrik.s.johansen@veloxit.no>> > wrote: > > I worked on this at the Lille sprint, the reason the shift to DejaVu > StrikeFonts hasn't been pushed (by me) is the BitBlt bug that Juan > fixed recently, and which is not in published VMs yet. > > Basically, due to overflows in the primitives when dealing with alpha > values, when you drag a window in Pharo the text turns partly > transparent, which is not very nice. > (Squeak doesn't cache the window being dragged in a Form, then bitblt > that instead of redrawing the entire window, so it doesn't experience > the same symptoms of the bug) > > If you want to use it in Core, evaluate StrikeFont installDejaVu, > before new VMs with the fix included become generally available I > wouldn't recommend using it by default though. > > Chers, > Henry > > On Nov 11, 2009, at 2:03 22PM, Adrian Lienhard wrote: > > > Yes, that is possible. We have the Cuis fonts integrated and can use > > them in the core. Like this we can also remove the (ugly) Accuny > > font. > > > > Any taker? > > > > Adrian > > > > On Nov 11, 2009, at 13:43 , Torsten Bergmann wrote: > > > >> The squeak trunk has a nice looking default font compared > >> to pharo core (without Freetype). > >> > >> Wasnt that related to some Cuis changes that were also > >> integrated into Pharo already? Any chance we can get that > >> too? Just curious... > >> > >> Thx > >> Torsten > >> > >> > >> -- > >> DSL-Preisknaller: DSL Komplettpakete von GMX schon fÃ¼r > >> 16,99 Euro mtl.!* Hier klicken: http://portal.gmx.net/de/go/dsl02 > >> > >> _______________________________________________ > >> Pharo-project mailing list > >> Pharo-project(a)lists.gforge.inria.fr > <mailto:Pharo-project@lists.gforge.inria.fr> > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > <mailto:Pharo-project@lists.gforge.inria.fr> > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > <mailto:Pharo-project@lists.gforge.inria.fr> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 11, 2010

Re: [Pharo-project] Problems with Strike fonts

by Henrik Sperre Johansen

You can always mix and match if you want by setting Fonts individually back to Bitmap DejaVu in the Font chooser. StrikeFont installDejaVu is simpler in the way that it automatically installs a font policy using it, it is also needed for the Bold oblique method headers mentioned in the report to display correctly, as who is derived from who is decided at install time. The underlined italic fonts beeing too narrow should be fixed either way. Cheers, Henry On 12.01.2010 00:02, Mariano Martinez Peck wrote: > I think I asked to quickly. Maybe evaluating this: > > FreeTypeCache clearCurrent. > > StrikeFont installDejaVu > > ??? > > > On Tue, Jan 12, 2010 at 12:01 AM, Mariano Martinez Peck > <marianopeck(a)gmail.com <mailto:marianopeck@gmail.com>> wrote: > > > > On Mon, Jan 11, 2010 at 11:56 PM, Henrik Sperre Johansen > <henrik.s.johansen(a)veloxit.no > <mailto:henrik.s.johansen@veloxit.no>> wrote: > > On 08.01.2010 16:24, Mariano Martinez Peck wrote: > > Thanks Henrik. However, I tried what you told me and still > is ugly :( > > > > Any idea? > > > > Thanks > > > > Mariano > > > > > http://code.google.com/p/pharo/issues/detail?id=1780 > > It fixes italic fonts of too narrow width, as well as bold italic > versions being synthetically derived from italic/bold Fonts when a > non-synthetic bold italic Font exists. > > > Thanks so much Henrik. I will try it tomorrow. > > I have a question: suppose I have running FreeTypes and I want to > put this StrikeFonts again, do you know which piece of code let me > do that ? > > It would be cool to give this possibily to the user of a dev image. > > Cheers > > Mariano > > > Cheers, > Henry > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > <mailto:Pharo-project@lists.gforge.inria.fr> > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Jan. 11, 2010

Re: [Pharo-project] Core font

by Mariano Martinez Peck

Henrik do you know the state of this issue with the VMs ? Maybe we can create an issue so that not to forget. cheers mariano On Wed, Nov 11, 2009 at 2:16 PM, Henrik Johansen < henrik.s.johansen(a)veloxit.no> wrote: > I worked on this at the Lille sprint, the reason the shift to DejaVu > StrikeFonts hasn't been pushed (by me) is the BitBlt bug that Juan > fixed recently, and which is not in published VMs yet. > > Basically, due to overflows in the primitives when dealing with alpha > values, when you drag a window in Pharo the text turns partly > transparent, which is not very nice. > (Squeak doesn't cache the window being dragged in a Form, then bitblt > that instead of redrawing the entire window, so it doesn't experience > the same symptoms of the bug) > > If you want to use it in Core, evaluate StrikeFont installDejaVu, > before new VMs with the fix included become generally available I > wouldn't recommend using it by default though. > > Chers, > Henry > > On Nov 11, 2009, at 2:03 22PM, Adrian Lienhard wrote: > > > Yes, that is possible. We have the Cuis fonts integrated and can use > > them in the core. Like this we can also remove the (ugly) Accuny > > font. > > > > Any taker? > > > > Adrian > > > > On Nov 11, 2009, at 13:43 , Torsten Bergmann wrote: > > > >> The squeak trunk has a nice looking default font compared > >> to pharo core (without Freetype). > >> > >> Wasnt that related to some Cuis changes that were also > >> integrated into Pharo already? Any chance we can get that > >> too? Just curious... > >> > >> Thx > >> Torsten > >> > >> > >> -- > >> DSL-Preisknaller: DSL Komplettpakete von GMX schon fÃ¼r > >> 16,99 Euro mtl.!* Hier klicken: http://portal.gmx.net/de/go/dsl02 > >> > >> _______________________________________________ > >> Pharo-project mailing list > >> Pharo-project(a)lists.gforge.inria.fr > >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project(a)lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 11, 2010

Re: [Pharo-project] [BUG] Bitmap DejaVu Sans / WideString

by Mariano Martinez Peck

this is still present? Henrik do you know if it is the same problem of the other thread ? Should we open a issue ? 2009/12/27 Lukas Renggli <renggli(a)gmail.com> > Bitmap DejaVu Sans displays WideStrings in unpredictable ways. > > Looks like there is a bug in StrikeFont? > > Lukas > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 11, 2010

Re: [Pharo-project] Problems with Strike fonts

by Mariano Martinez Peck

I think I asked to quickly. Maybe evaluating this: FreeTypeCache clearCurrent. StrikeFont installDejaVu ??? On Tue, Jan 12, 2010 at 12:01 AM, Mariano Martinez Peck < marianopeck(a)gmail.com> wrote: > > > On Mon, Jan 11, 2010 at 11:56 PM, Henrik Sperre Johansen < > henrik.s.johansen(a)veloxit.no> wrote: > >> On 08.01.2010 16:24, Mariano Martinez Peck wrote: >> > Thanks Henrik. However, I tried what you told me and still is ugly :( >> > >> > Any idea? >> > >> > Thanks >> > >> > Mariano >> > >> > >> http://code.google.com/p/pharo/issues/detail?id=1780 >> >> It fixes italic fonts of too narrow width, as well as bold italic >> versions being synthetically derived from italic/bold Fonts when a >> non-synthetic bold italic Font exists. >> > > Thanks so much Henrik. I will try it tomorrow. > > I have a question: suppose I have running FreeTypes and I want to put this > StrikeFonts again, do you know which piece of code let me do that ? > > It would be cool to give this possibily to the user of a dev image. > > Cheers > > Mariano > > >> >> Cheers, >> Henry >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > >

Jan. 11, 2010

Re: [Pharo-project] Problems with Strike fonts

by Mariano Martinez Peck

On Mon, Jan 11, 2010 at 11:56 PM, Henrik Sperre Johansen < henrik.s.johansen(a)veloxit.no> wrote: > On 08.01.2010 16:24, Mariano Martinez Peck wrote: > > Thanks Henrik. However, I tried what you told me and still is ugly :( > > > > Any idea? > > > > Thanks > > > > Mariano > > > > > http://code.google.com/p/pharo/issues/detail?id=1780 > > It fixes italic fonts of too narrow width, as well as bold italic > versions being synthetically derived from italic/bold Fonts when a > non-synthetic bold italic Font exists. > Thanks so much Henrik. I will try it tomorrow. I have a question: suppose I have running FreeTypes and I want to put this StrikeFonts again, do you know which piece of code let me do that ? It would be cool to give this possibily to the user of a dev image. Cheers Mariano > > Cheers, > Henry > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Jan. 11, 2010