Hi Stan,
Some are failing, as there are $' characters being passed through from the parser. Also, the literals check sees to be checking the node, rather than the node value.
You are right, the code that extracted arguments and temps unnecessarily put the names into $' characters. This is totally wrong and also breaks the highlighting in the browser. Instead of changing the tokenizer (as you proposed) I fixed the places where the nodes were collected. Like this there should be no more $' characters in the strings that are checked. Name: Refactoring-Spelling-lr.10 Author: lr Time: 12 January 2010, 12:16:16 am UUID: b40774a4-8371-42f4-883c-469d6fe1e020 Ancestors: Refactoring-Spelling-lr.9 - fixed the bug pointed out by Stan Shepherd that temps and arguments were not properly checked - this also fixes the issue of not highlighting typos in temps and arguments (which I looked into earlier today, but couldn't figure out the real cause)
There are some suggested changes in the same repository, that make the tests run green, and don't appear to affect the rest of Refactoring-Tests.
The tests are really cool. I would like to add them to the main repository, but two are broken depending on what checker is used: RBMacSpellChecker: #testLiteralValues and #testPoolVariable RBInternalSpellChecker: #testLiteralValues and #testClassComments Maybe that could be fixed by always using the internal one for the tests, but then I don't understand why the tests break. Does my fix not solve the whole problem? Lukas -- Lukas Renggli http://www.lukas-renggli.ch