November 2009 - Pharo-dev - lists.pharo.org

Re: [Pharo-project] rb broken in dev 10495

by Tudor Girba

Hi Lukas, I listed it below: codeBrowser | browser | browser := GLMTableLayoutBrowser new. browser row: #navigation; row: #details. browser showOn: #navigation; using: [ browser custom: self codeNavigator ]. browser showOn: #details; from: #navigation->#class; from: #navigation->#method; using: [ browser text display: [:cls | cls sourceText]; useExplicitNotNil; when: [:cls :method | cls notNil and: [method isNil] ]. browser text display: [:cls :method | method sourceText] ]. browser sendToOutside: #namespace from: #navigation->#namespace. browser sendToOutside: #class from: #navigation->#classe. browser sendToOutside: #method from: #navigation->#method. browser sendTo: ##navigation->#namespaceToSelect fromOutside: #namespaceToSelect. browser sendTo: ##navigation->#classToSelect fromOutside: #classToSelect. browser sendTo: ##navigation->#methodToSelect fromOutside: #methodToSelect. ^ browser Cheers, Doru On 16 Nov 2009, at 12:01, Lukas Renggli wrote: > Indeed, that looks like a bug in the parser of the RB. Can you send me > the code of > > MooseBrowsers>>codeBrowser > > Lukas > > > 2009/11/16 Tudor Girba <tudor.girba(a)gmail.com>: >> I used the "refactor class/rename" menu entry. >> >> I noticed the problem first in the PackageBrowser, and then >> reproduced >> it in the OBSystemBrowser. >> >> Cheers, >> Doru >> >> >> On 16 Nov 2009, at 10:13, Lukas Renggli wrote: >> >>> I cannot reproduce this using the RB tests and in the default OB >>> loaded into a Pharo-Core image. >>> >>> RB and OB in the dev image are broken. OB-Morphic, OB-Refactory, and >>> OB-Regex are dirty packages. There are numerous overrides that >>> subtly >>> break these packages. The menus of OB are messed up too. >>> >>> What browser are you using? What menu item are you using? In Pharo- >>> Dev >>> I have 3 different rename menus :-/ >>> >>> Lukas >>> >>> 2009/11/16 Tudor Girba <tudor.girba(a)gmail.com>: >>>> Hi, >>>> >>>> The refactorings are broken in the dev image 10495. I opened a >>>> ticket: >>>> http://code.google.com/p/pharo/issues/detail?id=1451 >>>> >>>> Cheers, >>>> Doru >>>> >>>> >>>> -- >>>> www.tudorgirba.com >>>> >>>> "No matter how many recipes we know, we still value a chef." >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> >>> >>> -- >>> Lukas Renggli >>> http://www.lukas-renggli.ch >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> -- >> www.tudorgirba.com >> >> "The coherence of a trip is given by the clearness of the goal." >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- www.tudorgirba.com "Next time you see your life passing by, say 'hi' and get to know her."

Nov. 16, 2009

Re: [Pharo-project] rb broken in dev 10495

by Lukas Renggli

Indeed, that looks like a bug in the parser of the RB. Can you send me the code of MooseBrowsers>>codeBrowser Lukas 2009/11/16 Tudor Girba <tudor.girba(a)gmail.com>: > I used the "refactor class/rename" menu entry. > > I noticed the problem first in the PackageBrowser, and then reproduced > it in the OBSystemBrowser. > > Cheers, > Doru > > > On 16 Nov 2009, at 10:13, Lukas Renggli wrote: > >> I cannot reproduce this using the RB tests and in the default OB >> loaded into a Pharo-Core image. >> >> RB and OB in the dev image are broken. OB-Morphic, OB-Refactory, and >> OB-Regex are dirty packages. There are numerous overrides that subtly >> break these packages. The menus of OB are messed up too. >> >> What browser are you using? What menu item are you using? In Pharo-Dev >> I have 3 different rename menus :-/ >> >> Lukas >> >> 2009/11/16 Tudor Girba <tudor.girba(a)gmail.com>: >>> Hi, >>> >>> The refactorings are broken in the dev image 10495. I opened a >>> ticket: >>> http://code.google.com/p/pharo/issues/detail?id=1451 >>> >>> Cheers, >>> Doru >>> >>> >>> -- >>> www.tudorgirba.com >>> >>> "No matter how many recipes we know, we still value a chef." >>> >>> >>> >>> >>> >>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>> >> >> >> >> -- >> Lukas Renggli >> http://www.lukas-renggli.ch >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > -- > www.tudorgirba.com > > "The coherence of a trip is given by the clearness of the goal." > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

Nov. 16, 2009

Re: [Pharo-project] rb broken in dev 10495

by Tudor Girba

I used the "refactor class/rename" menu entry. I noticed the problem first in the PackageBrowser, and then reproduced it in the OBSystemBrowser. Cheers, Doru On 16 Nov 2009, at 10:13, Lukas Renggli wrote: > I cannot reproduce this using the RB tests and in the default OB > loaded into a Pharo-Core image. > > RB and OB in the dev image are broken. OB-Morphic, OB-Refactory, and > OB-Regex are dirty packages. There are numerous overrides that subtly > break these packages. The menus of OB are messed up too. > > What browser are you using? What menu item are you using? In Pharo-Dev > I have 3 different rename menus :-/ > > Lukas > > 2009/11/16 Tudor Girba <tudor.girba(a)gmail.com>: >> Hi, >> >> The refactorings are broken in the dev image 10495. I opened a >> ticket: >> http://code.google.com/p/pharo/issues/detail?id=1451 >> >> Cheers, >> Doru >> >> >> -- >> www.tudorgirba.com >> >> "No matter how many recipes we know, we still value a chef." >> >> >> >> >> >> >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > > > -- > Lukas Renggli > http://www.lukas-renggli.ch > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project -- www.tudorgirba.com "The coherence of a trip is given by the clearness of the goal."

Nov. 16, 2009

[Pharo-project] [update 1.1] #11046

by Marcus Denker

11046 ----- Issue 1444: UndefinedObject allInstances isEmpty Issue 797: Pressing key (u grave) on french keyboard -> Error Marcus -- Marcus Denker -- denker(a)acm.org INRIA Lille-Nord Europe

Nov. 16, 2009

Re: [Pharo-project] rb broken in dev 10495

by Lukas Renggli

I cannot reproduce this using the RB tests and in the default OB loaded into a Pharo-Core image. RB and OB in the dev image are broken. OB-Morphic, OB-Refactory, and OB-Regex are dirty packages. There are numerous overrides that subtly break these packages. The menus of OB are messed up too. What browser are you using? What menu item are you using? In Pharo-Dev I have 3 different rename menus :-/ Lukas 2009/11/16 Tudor Girba <tudor.girba(a)gmail.com>: > Hi, > > The refactorings are broken in the dev image 10495. I opened a ticket: > http://code.google.com/p/pharo/issues/detail?id=1451 > > Cheers, > Doru > > > -- > www.tudorgirba.com > > "No matter how many recipes we know, we still value a chef." > > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > -- Lukas Renggli http://www.lukas-renggli.ch

Nov. 16, 2009

Re: [Pharo-project] slow method editor on syntax problems

by Henrik Johansen

Made issue 1452. It's an OCompletion problem, really. It reuses the text parsing from ECompletion, which calculates the ranges of the entire text on every invocation. (Scanning the entire SymbolTable once for every undefined token in the text...) Which I guess is fine when invocation is user-initiated, but not so much when it happens automatically as a response to every key press. What I am planning to do, is rewrite it to not discard the context between each invocation, but rather update the type of range under the cursor, and the extent of subsequent ranges based on whether a character/string has been inserted or removed. An easier solution would be to cache the last X queried undefined/partial symbols somewhere (Not in the parser-instance, as a new one is created by the context every time), as that would limit each parsing run to a worstcase of one full scan of the SymbolTable (for the current token). It means an extra cache that has to be maintained though, and feels like working around the problem instead of solving it, so I'd rather do the former. Cheers, Henry On Nov 14, 2009, at 9:45 10PM, Mariano Martinez Peck wrote: > You should then open a bug ticket! > > On Fri, Nov 13, 2009 at 1:03 PM, Alexandre Bergel <alexandre(a)bergel.eu> wrote: > > > I have not yet investigated the issue but since I guess I must not be > > the only one to see this happen maybe someone has some thoughts or is > > already on the issue (although I could not find an issue on the > > tracker). > > > +1 > You're not the only one > > Alexandre > > -- > _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: > Alexandre Bergel http://www.bergel.eu > ^~:;<you._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;. > > > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project

Nov. 16, 2009

Re: [Pharo-project] Status about compiler _ changes

by Martin McClure

Marcus Denker wrote: >> > No, the _ used to be rendered as a left-arrow. This comes from a time far, far away when there where less standards...build-your-own keyboad times. > It was a left-over from Smalltalk 72 which had lots of graphical characters as part of the language. Smalltalk-80 used a blend of ASCII-1963 and ASCII-1967. In ASCII-1963, character code 16r5E was actually an up-arrow, and 16r5F was actually a left arrow. In ASCII-1967 those codes are caret and underscore. Regards, -Martin

Nov. 16, 2009

[Pharo-project] rb broken in dev 10495

by Tudor Girba

Hi, The refactorings are broken in the dev image 10495. I opened a ticket: http://code.google.com/p/pharo/issues/detail?id=1451 Cheers, Doru -- www.tudorgirba.com "No matter how many recipes we know, we still value a chef."

Nov. 16, 2009

Re: [Pharo-project] Trailer format

by HernÃ¡n Morales Durand

Hi Michael, I was asking because I'm doing some mysterious tools, and I need to scan and gather information from all compiled methods in an image in a clean way. Cheers, HernÃ¡n 2009/11/15 Michael Roberts <mike(a)mjr104.co.uk>: > The Decompiler definitely has bugs. Â We disabled its tests because it > needs quite a lot of work post closure integration. > > Do you know what is referencing these compiled methods? i.e can they > possibly be run. Â Or is it just a question of clean up? > > thanks, > Mike > > On Sun, Nov 15, 2009 at 6:30 PM, Nicolas Cellier > <nicolas.cellier.aka.nice(a)gmail.com> wrote: >> 2009/11/15 HernÃ¡n Morales Durand <hernan.morales(a)gmail.com>: >>> Hi Nicolas, >>> Â Thanks for your comments. I've checked all CompiledMethods in a Core image >>> >>> | col | >>> col := OrderedCollection new: 20. >>> CompiledMethod allInstancesDo: [: cm | >>> Â Â Â Â [ RBParser >>> Â Â Â Â Â Â Â Â parseMethod: cm getSource asString >>> Â Â Â Â Â Â Â Â onError: [ :msg :pos | Â col add: (msg -> cm) ] ] >>> Â Â Â Â on: Error do: [: ex | ] ]. >>> col explore >>> >>> which gave me 9 instances with problems, 8 of them have source pointer >>> problems and they are uninstalled, in explorer : >>> >>> self collect: [: assoc | assoc value getSource asString ] >>> >> >> I recommend trying: >> Â Â ScriptLoader new cleanUpMethods. >> That should eliminate most copies of CompiledMethod and replace with >> an original. >> >> >>> After applying your patch and condensing changes and source files, >>> I've tried again >>> >>> CompiledMethod allInstances first getSource asString >>> >>> and the Decompiler raises now an exception, is this expected? >>> It would be too hard to correct the source pointer numbers of >>> uninstalled compiled methods? >>> >>> Cheers, >>> >>> HernÃ¡n >>> >> >> Decompiler might have bugs, some since closure refactorings, some >> older, but at least we know something is wrong. >> I always prefer a Debugger to a false response ! >> >> Instead of simply erasing the source pointer of un-installed >> CompiledMethod during condenseChanges/condenseSources, we could log >> their source. >> But it was already too late when I discovered this (while chasing >> MethodProperties)... >> >>> 2009/11/15 Nicolas Cellier <nicolas.cellier.aka.nice(a)gmail.com>: >>>> You should check this: >>>> Â CompiledMethod allInstances first isInstalled. >>>> >>>> If false, the answer probably is at >>>> http://code.google.com/p/pharo/issues/detail?id=1423 >>>> >>>> 2009/11/15 HernÃ¡n Morales Durand <hernan.morales(a)gmail.com>: >>>>> Hi all, >>>>> Â Possibly this is a bug. To reproduce it download a Pharo-Core (I'm >>>>> using #11045), update from servers and evaluate: >>>>> >>>>> CompiledMethod allInstances first getSource asString >>>>> >>>>> if you see something like the following result, some things could be wrong: >>>>> >>>>> Â '(firstCollection at: index) equals: Â a. >>>>> Â Â Â Â Â Â Â Â self assert: (secondCollection at: index) equals: Â b.] >>>>> >>>>> Â Â Â Â ' >>>>> >>>>> because that isn't a message pattern. The compiled method instance is >>>>> >>>>> (BlockClosure>>#newProcess "a CompiledMethod(1962)") >>>>> >>>>> and the source string is in PharoV10.sources, but >>>>> #fileIndexFromSourcePointer: is answering "2" which is the changes >>>>> file and should answer "1"... someone with a better understanding of >>>>> sources arithmetic may comment. >>>>> Cheers, >>>>> >>>>> HernÃ¡n >>>>> >>>>> _______________________________________________ >>>>> Pharo-project mailing list >>>>> Pharo-project(a)lists.gforge.inria.fr >>>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>>> _______________________________________________ >>>> Pharo-project mailing list >>>> Pharo-project(a)lists.gforge.inria.fr >>>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >>>> >>> >>> _______________________________________________ >>> Pharo-project mailing list >>> Pharo-project(a)lists.gforge.inria.fr >>> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> >> _______________________________________________ >> Pharo-project mailing list >> Pharo-project(a)lists.gforge.inria.fr >> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >> > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Nov. 16, 2009

Re: [Pharo-project] broken package browser

by HernÃ¡n Morales Durand

http://code.google.com/p/omnibrowser/issues/detail?id=4 2009/11/15 Tudor Girba <tudor.girba(a)gmail.com>: > The package browser is broken in the 10495 dev image. > > For some reason, the cmdFactories array contained nil objects, so I > had to patch it: > scanNodeCommands: ann > Â Â Â Â (cmdFactories select: [:ea | ea notNil and: [ea takesNodes]]) > Â Â Â Â Â Â Â Â do: [:ea | ann addFactory: ea] > > I am not sure whether the problem is really in OB or in the image. > > Cheers, > Doru > > > -- > www.tudorgirba.com > > "Obvious things are difficult to teach." > > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project(a)lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project >

Nov. 16, 2009