How to contribute to PharoLauncher?
Hi - Iâve added a few interesting features to PharoLauncher, but Iâm not sure what the steps are for contributing to a SmalltalkHub project? My proposed changes are as follows: - Change default image template name to include the parent folder name (e.g. Pharo 4.0 (beta)-540123 vs. 450123) - Add a new image command âImage Summaryâ that shows you the date of the last image modification as well as the contents of âdescription.txtâ - as I canât always remember why I have some old images kicking around (this change is quite basic - I couldnât see how best to create a nice popup window so I reused the deny: one with a new title. I did think possibly a hover over balloon or having something like the comments panel in Pharo - but its a modal dialog for now) - I changed the Run icon to a play button (as the process icon used - seemed a bit obscure) Tim
Hi tim I would love a sync from file possibility because I often remove directly folders and after the launcher is dead. I think that to contribute you should commits code in the inbox of the project. Damien is on vacation now but I'm sure he will welcome help.
Hi - Iâve added a few interesting features to PharoLauncher, but Iâm not sure what the steps are for contributing to a SmalltalkHub project?
My proposed changes are as follows: - Change default image template name to include the parent folder name (e.g. Pharo 4.0 (beta)-540123 vs. 450123) - Add a new image command âImage Summaryâ that shows you the date of the last image modification as well as the contents of âdescription.txtâ - as I canât always remember why I have some old images kicking around (this change is quite basic - I couldnât see how best to create a nice popup window so I reused the deny: one with a new title. I did think possibly a hover over balloon or having something like the comments panel in Pharo - but its a modal dialog for now) - I changed the Run icon to a play button (as the process icon used - seemed a bit obscure)
Tim
Stef - hmm thats an interesting feature as well, Iâll have a quick look. I tried committing my changes but I donât have commit writes on that project. I have entered a Fogbugz issue in the Launcher category and attached my slice to it. I still think Iâm doing something wrong with Monticello though. I thought I was getting to grips with it, but when I compared my slice against the smalltalk hub repo for Launcher, it shows a lot more outgoing changes than are mine. Mine are in there - but there are lots of other classes which I know I didnât change which show with a green tick as an outgoing change? It has me very confused. Yet - If I take a fresh Luancher image and then apply my Slice it works fine (and also shows just my changes). Could it be the Smalltalk hub repo has moved on a lot since the released version of Launcher - but then surely when diffing changes it would just consider what is in my slice. I think Iâm missing something important. Tim On 11 Aug 2014, at 11:49, stepharo <stepharo@free.fr> wrote:
Hi tim
I would love a sync from file possibility because I often remove directly folders and after the launcher is dead.
I think that to contribute you should commits code in the inbox of the project. Damien is on vacation now but I'm sure he will welcome help.
Hi - Iâve added a few interesting features to PharoLauncher, but Iâm not sure what the steps are for contributing to a SmalltalkHub project?
My proposed changes are as follows: - Change default image template name to include the parent folder name (e.g. Pharo 4.0 (beta)-540123 vs. 450123) - Add a new image command âImage Summaryâ that shows you the date of the last image modification as well as the contents of âdescription.txtâ - as I canât always remember why I have some old images kicking around (this change is quite basic - I couldnât see how best to create a nice popup window so I reused the deny: one with a new title. I did think possibly a hover over balloon or having something like the comments panel in Pharo - but its a modal dialog for now) - I changed the Run icon to a play button (as the process icon used - seemed a bit obscure)
Tim
Thanks Ben - I think that makes sense, as I did notice doing that kind of compare seemed to pull things into my image. As Iâm about to try again - Iâll try what you suggest (Iâm sure I will get there in the end). Tim On 11 Aug 2014, at 13:32, Ben Coman <btc@openInWorld.com> wrote:
Tim Mackinnon wrote:
Stef - hmm thats an interesting feature as well, Iâll have a quick look.
I tried committing my changes but I donât have commit writes on that project. I have entered a Fogbugz issue in the Launcher category and attached my slice to it.
I still think Iâm doing something wrong with Monticello though. I thought I was getting to grips with it, but when I compared my slice against the smalltalk hub repo for Launcher, it shows a lot more outgoing changes than are mine. Mine are in there - but there are lots of other classes which I know I didnât change which show with a green tick as an outgoing change? It has me very confused.
Yet - If I take a fresh Luancher image and then apply my Slice it works fine (and also shows just my changes).
Could it be the Smalltalk hub repo has moved on a lot since the released version of Launcher - but then surely when diffing changes it would just consider what is in my slice. I think Iâm missing something important.
Tim
I'm sure I've hit something similar before, but then I think I learnt to work around it or "just not go there" and those neurons have been garbage collected, so I have a thin grasp of this but here goes... A slice doesn't actually contain any code (only dependencies), and the <Changes> 't pull in those dependencies, so you are kind of comparing nothing against an a whole image, so everything is changed. I find I must check the changes of individual packages of a slice. It would be real-nice to be able to get the changes of a whole slice versus Pharo/main in one go, but I think that behaviour is just missing.
Btw, loading a slice into a fresh image <Changes> and <Merge> is a different function, so all the changes for the whole slice are shown in one go. cheers -ben
On 11 Aug 2014, at 11:49, stepharo <stepharo@free.fr> wrote:
Hi tim
I would love a sync from file possibility because I often remove directly folders and after the launcher is dead.
I think that to contribute you should commits code in the inbox of the project. Damien is on vacation now but I'm sure he will welcome help.
Hi - Iâve added a few interesting features to PharoLauncher, but Iâm not sure what the steps are for contributing to a SmalltalkHub project?
My proposed changes are as follows: - Change default image template name to include the parent folder name (e.g. Pharo 4.0 (beta)-540123 vs. 450123) - Add a new image command âImage Summaryâ that shows you the date of the last image modification as well as the contents of âdescription.txtâ - as I canât always remember why I have some old images kicking around (this change is quite basic - I couldnât see how best to create a nice popup window so I reused the deny: one with a new title. I did think possibly a hover over balloon or having something like the comments panel in Pharo - but its a modal dialog for now) - I changed the Run icon to a play button (as the process icon used - seemed a bit obscure)
Tim
Stef - from what I can see, I think the refresh icon on the toolbar was supposed to do that - but it didnât. Iâm proposing a fix to make that work, as well as having file operations check the file they are working on is actually there - before attempting their operation (and tell you if not, and cause a refresh). Itâs not beautiful - but its not so bad (but Iâll see what Damien and Ben think). Tim On 11 Aug 2014, at 11:49, stepharo <stepharo@free.fr> wrote:
Hi tim
I would love a sync from file possibility because I often remove directly folders and after the launcher is dead.
I think that to contribute you should commits code in the inbox of the project. Damien is on vacation now but I'm sure he will welcome help.
Hi - Iâve added a few interesting features to PharoLauncher, but Iâm not sure what the steps are for contributing to a SmalltalkHub project?
My proposed changes are as follows: - Change default image template name to include the parent folder name (e.g. Pharo 4.0 (beta)-540123 vs. 450123) - Add a new image command âImage Summaryâ that shows you the date of the last image modification as well as the contents of âdescription.txtâ - as I canât always remember why I have some old images kicking around (this change is quite basic - I couldnât see how best to create a nice popup window so I reused the deny: one with a new title. I did think possibly a hover over balloon or having something like the comments panel in Pharo - but its a modal dialog for now) - I changed the Run icon to a play button (as the process icon used - seemed a bit obscure)
Tim
participants (3)
-
Ben Coman -
stepharo -
Tim Mackinnon