I will integrate some of your additions in Pharo (the enhancing of API). Esteban this is just improving Spec API so it does not break anything. Le 7/2/16 10:24, Hernán Morales Durand a écrit :
Thanks, I will check later because it's 6 a.m. and I have to sleep :) Cheers,
Hernán
2016-02-07 6:13 GMT-03:00 stepharo <stepharo@free.fr <mailto:stepharo@free.fr>>:
Hi hernan
some feedback/questions while waiting for my kids...
============= "protocol: *SpecUIAddOns" includesNameBeginsWith: aString " Answer whether the receiver begins with aString. "
^ self asLowercase = aString first asLowercase
does not look like doing what it says.
===================================== I do not get
specModalParent " Receiver cannot be modal parent, answer a default (morphic world) "
^ [ self currentWorld ] on: Error do: [ : ex | UIManager default currentWorld ]
=====================================
In searchableTree
either use tree or self tree
"protocol: *SpecUIAddOns" autoMultiSelection: aBoolean
self tree autoMultiSelection: aBoolean
It was interested to see that you added a lot of methods
methods self xxxmodel methods
I was against them. Now the point is
if we ban such idiom
remove: anItem self listModel remove: anItem
then (beside exposing the model which would be ok for me if we consider it as a port)
we have the problem of encapsulating more complex behavior such
removeAllItems
self listModel removeAll. self updateList
So probably that
remove: anItem self listModel remove: anItem
is better
Stef