On 27 Mar 2022, at 20:29, christian.haider@smalltalked-visuals.com wrote:
Hi Stef,
Great! Thank you for your work. Good example for the tonel format.
Which sources were you using? How did you generate this? Do you use VW to create the output?
For the last ESUG (2.5 years ago â sigh), I already did the transformation for Values for Pharo. Thanks to you, I revised them and published the result on GitHub (https://github.com/PortingPDFtalk/PharoValues <https://github.com/PortingPDFtalk/PharoValues>) and added a Pharo porting page to the wiki (https://wiki.pdftalk.de/doku.php?id=pharoport <https://wiki.pdftalk.de/doku.php?id=pharoport>). Please have a look.
The fileouts are for Pharo versions 6.1, 7.0, 8.0 and 9.0 (7.0 to 9.0 have identical sources). The sources load without errors or warnings and all 27 tests pass.
Some of the problems in your code have to do with OrderedDictionary as superclass of Valuemap. When I did my first round on the port, I had a class OrderedDictionary in my Values implementation. Unfortunately, OrderedDictionary does not work as I expected.
(OrderedDictionary with: #a -> 1 with: #b -> 2) = (OrderedDictionary with: #b -> 2 with: #a -> 1)
answers true, although the order is different. Therefore, it cannot be used as value.
I have added an issue tracker entry: https://github.com/pharo-project/pharo/issues/11065 <https://github.com/pharo-project/pharo/issues/11065> To me it looks like yes, it #= should take order into account. Marcus