On Sun, Jul 28, 2013 at 04:59:32AM +0200, Igor Stasenko wrote:
On 28 July 2013 03:46, Pierce Ng <pierce@samadhiweb.com> wrote:
Maybe this is the wrong list to ask, but how do I contribute this to Pharo? http://www.pharo-project.org/community/how-to-contribute
Hi Igor, Thanks. From there this link http://pharo.gforge.inria.fr/licenseDocuments/ throws a 404.
About unix sockets: i see the changes is not really big and easy to integrate. My only question regarding this, how do you think, maybe it make sense to have a separate class for it, so users can tell:
UnixSocket new
instead of
Socket newIPC
I went for minimal change. As Socket already has newTCP and newUDP instance creation methods, I use newICP. Since the VM apparently also supports IPv6, I'd suggest to defer on creating separate classes until there is more experience using Unix domain *and* IPv6 TCP/UDP sockets, alongside current code that is using TCP/UDP over IPv4.
i also think that if socket creation failed, the code should throw an error rather than return nil.
Ditto, I followed current behaviour. Not quite Smalltalk-like, I agree. Cheers. -- Pierce Ng http://samadhiweb.com/blog/