Joachim, On 09 Dec 2013, at 11:09, jtuchel@objektfabrik.de wrote:
Hi Sven,
thanks for porting this and making it available. I will re-integrate your improvements in the VAST code if that's okay with you.
Yes, please do, that is the least we could do back. All Pharo code is MIT licensed.
Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-)))
And the code is already part of Pharo 3.0 (it went through the whole process with automatic validation by the CI system and finally integration): One way to see the changes is via github https://github.com/pharo-project/pharo-core/commit/76bf0c7bf67d5ce70f6b70437... So if you download Pharo 3.0 today should get a version 30633 or later. Youâll find your code in QuotedPrintableMimeConverter[Tests]. Thanks again ! Regards, Sven
Joachim
Am 08.12.13 23:49, schrieb Sven Van Caekenberghe:
On 08 Dec 2013, at 19:51, Sven Van Caekenberghe <sven@stfx.eu> wrote:
Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good. Done:
https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete
RESOLVED
Slice in 3.0 inbox:
=== Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1 Author: SvenVanCaekenberghe Time: 8 December 2013, 11:45:09.148454 pm UUID: af015099-e48b-47f5-9553-840fca62d8e2 Ancestors: Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92
A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests.
Note that the older code lacked the encoding part and had no tests at all. ===
Sven
-- ----------------------------------------------------------------------- Objektfabrik Joachim Tuchel mailto:jtuchel@objektfabrik.de Fliederweg 1 http://www.objektfabrik.de D-71640 Ludwigsburg http://joachimtuchel.wordpress.com Telefon: +49 7141 56 10 86 0 Fax: +49 7141 56 10 86 1