That was the impression I had :) Now I know I need to explain it and document it better :) Ben On Jul 13, 2013, at 6:15 PM, Andrei Vasile Chis <chisvasileandrei@gmail.com> wrote:
Thanks. Now I see I did't got how to rebuild the widget properly :)
Andrei
On Sat, Jul 13, 2013 at 1:10 AM, Benjamin <benjamin.vanryseghem.pharo@gmail.com> wrote: Committed :)
Ben
On Jul 12, 2013, at 8:26 PM, Andrei Vasile Chis <chisvasileandrei@gmail.com> wrote:
On Fri, Jul 12, 2013 at 2:14 PM, Benjamin <benjamin.vanryseghem.pharo@gmail.com> wrote: Smalltalk hub is not trig erring notifications (yet) :)
Now you should be added as a contributor, so you can commit :)
Andrei
Ben
On Jul 12, 2013, at 2:09 PM, Andrei Vasile Chis <chisvasileandrei@gmail.com> wrote:
On Fri, Jul 12, 2013 at 1:59 PM, Benjamin <benjamin.vanryseghem.pharo@gmail.com> wrote: I reviewed your code. There was some misunderstanding I think about how to rebuild widgets :)
I patch your version so the toolbar is only responsible of its own layout, and the ChangingButton too.
Super. Thanks a lot :)
I can not commit in your repo since I do not have proper rights :)
I tried to add you as a contributor but nothing happened. Did you receive perhaps some notification?
Andrei