A quick review of your code, just looking at what is on gitHub: At class side, the layout method looks really good ( https://github.com/kilon/Nireas/blob/master/Nireas.package/Nireas.class/clas... ) I think it is hard to get something cleaner than that in any textual UI framework. initializeWidgets ( https://github.com/kilon/Nireas/blob/master/Nireas.package/Nireas.class/inst... ) Lines 4 to 11 are not necessary. Just remove them Lines 20 to 26 introduce 7 methods that are not needed, you could include this in initializeWidgets itself. So we go from 36 to 29 methods at instance side. initialize ( https://github.com/kilon/Nireas/blob/master/Nireas.package/Nireas.class/inst... ) Lines 7 through 12 introduce 6 methods that are not needed, you could include this in initialize itself. So we go from 29 to 23 methods at instance side. A quick look at the method counts 13 accessors. In my book, accessors donât count. So we go from 23 to 10 methods at instance side. 10 methods for a UI class is not so bad, is it?
On Dec 19, 2014, at 20:18, kilon alios <kilon.alios@gmail.com> wrote:
yes you can find my code here
https://github.com/kilon/Nireas
On Sat, Dec 20, 2014 at 12:17 AM, Johan Fabry <jfabry@dcc.uchile.cl> wrote:
36 methods for your UI is way too much. I suppose you are doing something wrong somewhere. You should not need all of these steps.
---> Save our in-boxes! http://emailcharter.org <--- Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile