Thank you volkert for the correction! On 12 June 2015 at 11:05, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
If you want to open a workspace or a playground we should use:
viewContentsInWorkspace "View the contents of my selected file in a new workspace"
| aString | self reference streamWritable: false do: [ :stream | aString := stream setConverterForCode contentsOfEntireFile ]. Smalltalk tools workspace openContents: aString label: 'Workspace from ' , self reference basename
BUT! If we open a file which is not a Smalltalk code the syntax coloring is really a bad idea. Someone know if we can desable the syntax coloring for an instance of the playground or workspace ?
If we can't we should change the name on the menu and not the action of the menu. Thank.
On 6 June 2015 at 16:37, volkert <volkert@komponentenwerkstatt.de> wrote:
Is this change resonable. I have no idea, what the Design-Idea behind the UIManager what services is should provide. May be it make sense to have the extra services on UIManager, but think the bug is in FileList>>viewContentsInWorkspace and not in UIManager.
---- I propose for Workspace to change the current code:
FileList>>viewContentsInWorkspace "View the contents of my selected file in a new workspace" | aString | self reference streamWritable: false do: [ :stream| aString := stream setConverterForCode contentsOfEntireFile ]. UIManager default edit: aString label: 'Workspace from ', self reference basename <----- WRONG
to :
FileList>>viewContentsInWorkspace "View the contents of my selected file in a new workspace" | aString | self reference streamWritable: false do: [ :stream| aString := stream setConverterForCode contentsOfEntireFile ]. Workspace openContents: aString label: 'Workspace from ', self reference basename
And i also proposse the add a Playground case.
New Method:
FileList>>viewContentsInPlayground "View the contents of my selected file in a new playground" | aString | self reference streamWritable: false do: [ :stream| aString := stream setConverterForCode contentsOfEntireFile ]. GTPlayground openContents: aString label: 'Playground from ', self reference basename.
and also FileList>>serviceViewContentsInPlayground and the case in ListList>>itemsForAnyFile.
If ok, i can fix Workspace and add Playground menu to FileList, after i have figured out how to send an fix ;-)
BW, Volkert
Am 03.06.2015 um 16:40 schrieb Ben Coman:
Or do we now want such to open in Playground?
btw, these are the relevant methods. FileList>>FileList>>viewContentsInWorkspace FileList>>viewContentsInWorkspace
cheers -ben
On Wed, Jun 3, 2015 at 6:57 PM, volkert <volkert@komponentenwerkstatt.de> wrote:
The File Browser has a Context Menu "Workspace with Contents". It opens an Edit Window (String Morph), but not a Workspace ...
Is the Menu-Title wrong or the implementation?
BW, Volkert
-- Cheers Cyril Ferlicot
-- Cheers Cyril Ferlicot