On Wed, Oct 11, 2017 at 09:50:46PM +0200, Herby Voj????k wrote:
stephan wrote:
On 11-10-17 20:33, Herby Voj????k wrote:
127 is general, is not sqlite-specific. Fixes any case where primary key is not primitive and has converter.
Should 127 and 129 be merged first, and should current development be promoted to release? And why is 128 missing?
Stephan
129 is from different author, who skipped upload of its 127 and 128 (probably intermediates).
127 is mine, fixes IMO overoptimized case for DirectMapping which unlike its superclass (thus all the other mappings as there is no other specialization), stopped converting primary keys to db value in fk->pk relationships.
129 is mine. 129 is dated July 2016 while 127 is dated August 2017, which I guess accounts for why I based 129 on 126. On Wed, Oct 11, 2017 at 11:31:17AM +0200, stephan wrote:
On 06-10-17 17:22, Herby Voj????k wrote:
Any chance of incorporating fixes 127 / 129?
Sure, as soon as someone tells me they are safe to add. I am just testing Glorp with P3 and Postgres now, and don't have the capacity to verify these changes other than by just reading the delta.
Stephan
129 has been available since July 2016 and was promoted to #development by Pierce in January 2017. I've been using it without any problems since I submitted it in July 2016. Cheers, Alistair