And thank's a lot, Juraj. Very impressive review :). I will answer questions later 2018-01-17 16:04 GMT+01:00 Denis Kudriashov <dionisiydk@gmail.com>:
Hy Juraj,
Do not spend time in Calypso part and even do not read it :). It is super outdated and very draft. I am now working on it.
I will look you changes soon.
2018-01-17 15:07 GMT+01:00 Juraj Kubelka <juraj.kubelka@icloud.com>:
Hi Denis,
I finally read Section 3. I left two comments where I do not understand why something happens. I will appreciate a further explanation :-)
Here is the pull request: https://github.com/Sq uareBracketAssociates/Booklet-Infrastructure/pull/2
I have found out that the code in the Calypso chapter does not work. I was able to change some of them. Do you want me to commit what I was able to change? Well, you should check if the changes are correct.
Cheers, Juraj
On Dec 27, 2017, at 13:20, Denis Kudriashov <dionisiydk@gmail.com> wrote:
Hi Juraj.
You can find new version here https://github.com/Square BracketAssociates/Booklet-Infrastructure <https://github.com/SquareBracketAssociates/Booklet-Infrastructure>. It is still draft version but in general all parts are covered now.
2017-12-06 12:47 GMT+01:00 Juraj Kubelka <juraj.kubelka@icloud.com>:
Hi Denis,
Thank you. Let me know. I will be happy to help.
Juraj
On Dec 5, 2017, at 18:43, Denis Kudriashov <dionisiydk@gmail.com> wrote:
Hi Juraj.
Yes. documentation needs to be improved. I made only pass on it. Now there is new Commander version. The code still in dev branch <https://github.com/dionisiydk/Commander/tree/dev>. The basic idea is same but some names are changed and internally it is based on ClassAnnotation's <https://github.com/dionisiydk/ClassAnnotation>. It became more simple and flexible. This week I should release new Calypso version. And after I will work on documentation for both projects. Commander will be first. And next week I will have update on it.
2017-12-05 21:05 GMT+01:00 Juraj Kubelka <juraj.kubelka@icloud.com>:
Hi,
I like the idea of the Commander library https://github.com/dio nisiydk/Commander I am trying to understand how to use it, but I struggle to understand it as documentation includes quiete complex examples: https://ci.inria.fr/pharo-contribution/view/Books/ job/PharoBookWorkInProgress/lastSuccessfulBuild/artifact/boo k-result/Commander/Commander.html
I believe that it would be useful to have a tutorial that shows:
1. create a command CmdOne including methods, 2. create a activator ActOne including methods, 3. create a context CtxOne including methods, 4. execute <I do not know what> and you obtain a collection with one item (CmdOne instance?) 5. create command CmdTwo with some methods 6. execute <I do not know what> and you obtain a collection with two items
Then next section could describe how to make a UI on top of this.
Thank's for initiative. It is exactly what I will do.
Learning it by exploring Calypso is too complex, because it involves more objects and I actually do not see how to do the previous steps.
I agree, current version is a bit complicated inside. But it is already fixed. And there will be update soon.
I will be happy to help with the documentation. My question is: How can I proceed the mentioned steps?
I would appreciate for your help. I will call you for review next week.
Best regards, Denis
Thanks, Juraj