Hi Gabriel, I agree with you that my "extract to temp" may be not really a refactoring anymore. And maybe you're right about adding extra option, I should think about it. Thanks Mark 2014-07-23 13:33 GMT+02:00 Gabriel Cotelli <g.cotelli@gmail.com>:
Hi Mark,
Thanks for taking care of improving the refactoring tools.
Just a side note, if you modify the Extract to temporary refactoring to change all the references (as your blog post suggest) then exists cases when this is no longer a refactoring. If the extracted code has side effects is not the same to send this messages one or several times and a refactoring is supposed to be safe.
I think you should let the old behavior as a refactoring, and add this new one (very useful indeed) making clear that is not a refactoring.
Regards, Gabriel
On Tue, Jul 22, 2014 at 6:00 AM, Mark Rizun <mrizun@gmail.com> wrote:
Hi everyone,
This is a summary of what is done on improving refactorings. /Refactoring(enhancement)/ - Extract to temporary(renaming duplicates) - Rename method(permutation of args) - Rename inst var(renames accessors) For more details read my blog: http://myfuncoding.blogspot.fr/2014/07/improved-refactorings.html Feedback & re-tweets are welcome:)
Best, Mark
-- View this message in context: http://forum.world.st/Refactoring-project-improvements-tp4769273.html Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.