On Thu, Dec 19, 2013 at 11:07 AM, Sergi Reyner <sergi.reyner@gmail.com> wrote:
- Class names are awfully chosen. Besides almost every one of them having IRC as a "namespace" prefix, some like IRCUser don´t convey enough meaning.
having a prefix is a common pattern. I don't see the problem of IRCUser as a name.
- IRCConfiguration could be replaced by a dictionary since it´s nothing more than a bunch of data. But the, on the other hand, it could encapsulate validation on the settings to say something.
I'm not sure what would be the gain of transforming a proper class into a dictionary. We usually do the opposite : creating classes out of collection usage. I would keep the class and give it a responsibility.
- Is PetitParser overkill for the time of parsing required? Are regular expressions a better fit for this task?
I don't know what parsing is required. But if it works, I would keep it the way it is.
- Do I keep the Glamour browsers? I´m rather partial to them :D
Glamour is really great to write interfaces and I really like it. Now, if you develop a browser on top of glamour, you also need the moldable glamour debugger. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." Winston Churchill