Hi Hernan how did you reproduce the bug? Because it would be nice to fix it. Stef On 24 Dec 2013, at 18:48, Hernán Morales Durand <hernan.morales@gmail.com> wrote:

I have tried in Pharo 2.0 configurations from Config Browser (ConfigurationOfXMLParser-StephaneDucasse.16) and latest from http://www.smalltalkhub.com/mc/PharoExtras/XMLParser/main (ConfigurationOfXMLParser-monty.37) and both have this bug.

Hernán

2013/12/24 Stéphane Ducasse <stephane.ducasse@inria.fr> Hi Satoshi

Did you try with the latest configuration of XMLParser? Because I do not know what it is in Moose. Stef

On 23 Dec 2013, at 18:26, NISHIHARA Satoshi <goonsh@gmail.com> wrote:

...

Hello

using: Pharo3.0 Latest update: #30659 (it occurs same error to Pharo2.0 Latest update: #20628) (Moose 4.9 with XML-Parser (DamienCassou.143) has no_err)

1. load XMLParser (StephaneDucasse.16) from Configuration browser 2. select and inspect it below: ^ XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.0 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd"> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> <part id="P1"> <measure number="1"> <attributes> <divisions>1</divisions> <key> <fifths>0</fifths> </key> <time> <beats>4</beats> <beat-type>4</beat-type> </time> <clef> <sign>G</sign> <line>2</line> </clef> </attributes> <note> <pitch> <step>C</step> <octave>4</octave> </pitch> <duration>4</duration> <type>whole</type> </note> </measure> </part> </score-partwise> ' readStream.

3. and get DNU: SmallInteger>>asciiValue

'case of XMLZincClient>>#get: 'http://www.musicxml.com/dtds/partwise.dtd' timeout: ... onError: ... returns binaryStream?

-- -- "NISHIHARA Satoshi" [:goonsh :nsh | ^ nishis perform: goonsh with: nsh] <PharoDebug.log>

ok I missed the example in the mail of satoshi I will try to have a look or at leat write a test. On 25 Dec 2013, at 19:04, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:

Hi Hernan

how did you reproduce the bug? Because it would be nice to fix it.

Stef

On 24 Dec 2013, at 18:48, Hernán Morales Durand <hernan.morales@gmail.com> wrote:

...

I have tried in Pharo 2.0 configurations from Config Browser (ConfigurationOfXMLParser-StephaneDucasse.16) and latest from http://www.smalltalkhub.com/mc/PharoExtras/XMLParser/main (ConfigurationOfXMLParser-monty.37) and both have this bug.

Hernán

2013/12/24 Stéphane Ducasse <stephane.ducasse@inria.fr> Hi Satoshi

Did you try with the latest configuration of XMLParser? Because I do not know what it is in Moose. Stef

On 23 Dec 2013, at 18:26, NISHIHARA Satoshi <goonsh@gmail.com> wrote:

...

Hello

using: Pharo3.0 Latest update: #30659 (it occurs same error to Pharo2.0 Latest update: #20628) (Moose 4.9 with XML-Parser (DamienCassou.143) has no_err)

1. load XMLParser (StephaneDucasse.16) from Configuration browser 2. select and inspect it below: ^ XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.0 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd"> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> <part id="P1"> <measure number="1"> <attributes> <divisions>1</divisions> <key> <fifths>0</fifths> </key> <time> <beats>4</beats> <beat-type>4</beat-type> </time> <clef> <sign>G</sign> <line>2</line> </clef> </attributes> <note> <pitch> <step>C</step> <octave>4</octave> </pitch> <duration>4</duration> <type>whole</type> </note> </measure> </part> </score-partwise> ' readStream.

3. and get DNU: SmallInteger>>asciiValue

'case of XMLZincClient>>#get: 'http://www.musicxml.com/dtds/partwise.dtd' timeout: ... onError: ... returns binaryStream?

-- -- "NISHIHARA Satoshi" [:goonsh :nsh | ^ nishis perform: goonsh with: nsh] <PharoDebug.log>

XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.0 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd"> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> </score-partwise> ' readStream. produces the error while XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> </score-partwise> ' readStream. does not. Stef

I do not know but monty adding worth behavior. Now we could always revert to the previous configuration version. Stef Here is the mail that he sent a while ago: These updates add validation against internal and external DTDs, proper replacement of general and parameter entites, customizable resolution of external parsed entities using Zinc and FileSystem, awareness of notations and unparsed entities, preservation of the internal DTD subset by the DOM parser (so printing a parsed doc with a DTD will produce approximately what was input), line numbers reporting in error messages, and better well-formed and validity constraints. I had to largely rewrite the tokenizer to make everything work, but I followed the spec closely, and it is about the same speed as long as there is no DTD to validate against. One problem is that while the tests I added and the existing tests all pass, for some reason helper messages in some test classes starting with "should" (in the style of should:raise:) are being interpreted as tests and run by TestRuner, even though they don't begin with "test" and take arguments! This is possibly a bug in TestRunner. Another problem is that there are so many deprecated methods cluttering up classes, some of which have been deprecated for years! It is confusing and hard to see which methods to use just by browsing the protocols. I would really suggest using this code to get rid of the XML-Parser methods that have been deprecated for at least a year: expiry := 1 year. (SystemNavigation default allClassesInPackageNamed: 'XML-Parser') do: [:class | class selectors do: [:selector | | compiledMethod timeStamp | compiledMethod := class compiledMethodAt: selector. timeStamp := compiledMethod timeStamp copyAfter: Character space. (compiledMethod isDeprecated and: [(DateAndTime now - (DateAndTime fromString: timeStamp)) > expiry]) ifTrue: [class removeSelector: selector]]]. I ran and checked it myself and it doesn't break anything. Running the above with XML-Writer-Core might not be a bad idea either. I also updated BitmapCharacterSet to use less memory.

In an image with XML-Parser-NorbertHartl.141 both expression work.

I see that in PharoExtras/XMLParser there are many commits by ‘monty’ all with empty log messages - how is that possible ??

On 27 Dec 2013, at 16:57, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote:

...

XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.0 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd"> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> </score-partwise> ' readStream.

produces the error while

XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> </score-partwise> ' readStream.

does not.

Stef

I read a bit about internal public and other dtd and it looks like this is ok Ahhh. The bug was showing a parser problem…. so I could not get that it was related to the network :)

Because monty's code downloads the DTD for validation from

http://www.musicxml.org/dtds/partwise.dtd

I should check if is the "right thing to do" because it would increase parsing time significantly. At least it should be an option.

Cheers,

Hernan

2013/12/27 Stéphane Ducasse <stephane.ducasse@inria.fr> XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.0 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd"> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> </score-partwise> ' readStream.

produces the error while

XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> </score-partwise> ' readStream.

does not.

Stef

In any case, it is strange that the items in the CharacterSet cannot be printed by the EyeInspector. GTInspector shows them properly (see attached).

It gets even worse. Try doing this in a fresh Pharo 3.0 image:

CharacterSet allCharacters explore

probably because the explorer is using at: something. but CharacterSet allCharacters inspect works with the problems I mentioned.

and you will get a DNU that 'Instances of CharacterSet are not indexable'.

Cheers, Doru

<MessageNotUnderstood: SmallInteger>>asciiValue.png>

On Fri, Dec 27, 2013 at 6:47 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote: I read a bit about internal public and other dtd and it looks like this is ok

Ahhh.

The bug was showing a parser problem…. so I could not get that it was related to the network :)

...

Because monty's code downloads the DTD for validation from

http://www.musicxml.org/dtds/partwise.dtd

I should check if is the "right thing to do" because it would increase parsing time significantly. At least it should be an option.

Cheers,

Hernan

2013/12/27 Stéphane Ducasse <stephane.ducasse@inria.fr> XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <!DOCTYPE score-partwise PUBLIC "-//Recordare//DTD MusicXML 3.0 Partwise//EN" "http://www.musicxml.org/dtds/partwise.dtd"> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> </score-partwise> ' readStream.

produces the error while

XMLDOMParser parse: '<?xml version="1.0" encoding="UTF-8" standalone="no"?> <score-partwise version="3.0"> <part-list> <score-part id="P1"> <part-name>Music</part-name> </score-part> </part-list> </score-partwise> ' readStream.

does not.

Stef

-- www.tudorgirba.com

"Every thing has its own flow"