review pull request changes view
When reviewing a pull request, I see this in the changes view: The tab title says "left working copy / right incoming update" but the code on the right side is what is current in my image [image: Inline-Bild 1] And I don't think "working copy" is the correct naming, as this view lets me diff changes within that history, so it may be that none of this code is actually in my "working copy", no ?
2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com>:
When reviewing a pull request, I see this in the changes view: The tab title says "left working copy / right incoming update" but the code on the right side is what is current in my image
[image: Inline-Bild 1]
And I don't think "working copy" is the correct naming, as this view lets me diff changes within that history, so it may be that none of this code is actually in my "working copy", no ?
BTW, this is extremly unstable, reviewing a pull request, crashes a lot (the vm)
On 1 Sep 2017, at 14:51, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>>: When reviewing a pull request, I see this in the changes view: The tab title says "left working copy / right incoming update" but the code on the right side is what is current in my image
<grafik.png>
And I don't think "working copy" is the correct naming, as this view lets me diff changes within that history, so it may be that none of this code is actually in my "working copy", no ?
BTW, this is extremly unstable, reviewing a pull request, crashes a lot (the vm)
on windows?
2017-09-01 15:03 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 14:51, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com>:
When reviewing a pull request, I see this in the changes view: The tab title says "left working copy / right incoming update" but the code on the right side is what is current in my image
<grafik.png>
And I don't think "working copy" is the correct naming, as this view lets me diff changes within that history, so it may be that none of this code is actually in my "working copy", no ?
BTW, this is extremly unstable, reviewing a pull request, crashes a lot (the vm)
on windows?
Yes, attached a another crash.dmp (maybe it helps)
On 1 Sep 2017, at 15:50, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 15:03 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com <mailto:estebanlm@gmail.com>>:
On 1 Sep 2017, at 14:51, Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>> wrote:
2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>>: When reviewing a pull request, I see this in the changes view: The tab title says "left working copy / right incoming update" but the code on the right side is what is current in my image
<grafik.png>
And I don't think "working copy" is the correct naming, as this view lets me diff changes within that history, so it may be that none of this code is actually in my "working copy", no ?
BTW, this is extremly unstable, reviewing a pull request, crashes a lot (the vm)
on windows?
Yes,
attached a another crash.dmp (maybe it helps)
<crash.dmp>
can you tell me the PR you were analysing ? Esteban
On 1 Sep 2017, at 16:02, Esteban Lorenzano <estebanlm@gmail.com> wrote:
On 1 Sep 2017, at 15:50, Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>> wrote:
2017-09-01 15:03 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com <mailto:estebanlm@gmail.com>>:
On 1 Sep 2017, at 14:51, Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>> wrote:
2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>>: When reviewing a pull request, I see this in the changes view: The tab title says "left working copy / right incoming update" but the code on the right side is what is current in my image
<grafik.png>
And I don't think "working copy" is the correct naming, as this view lets me diff changes within that history, so it may be that none of this code is actually in my "working copy", no ?
BTW, this is extremly unstable, reviewing a pull request, crashes a lot (the vm)
on windows?
Yes,
attached a another crash.dmp (maybe it helps)
<crash.dmp>
can you tell me the PR you were analysing ?
ah, and btw⦠can you update with latest dev-0.5? I made some changes that may help there that I still do not merge into master. Esteban
Esteban
2017-09-01 16:13 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 16:02, Esteban Lorenzano <estebanlm@gmail.com> wrote:
On 1 Sep 2017, at 15:50, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 15:03 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 14:51, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com>:
When reviewing a pull request, I see this in the changes view: The tab title says "left working copy / right incoming update" but the code on the right side is what is current in my image
<grafik.png>
And I don't think "working copy" is the correct naming, as this view lets me diff changes within that history, so it may be that none of this code is actually in my "working copy", no ?
BTW, this is extremly unstable, reviewing a pull request, crashes a lot (the vm)
on windows?
Yes,
attached a another crash.dmp (maybe it helps)
<crash.dmp>
can you tell me the PR you were analysing ?
ah, and btw⦠can you update with latest dev-0.5? I made some changes that may help there that I still do not merge into master.
update what? pharo ?
Esteban
Esteban
On Fri, Sep 1, 2017 at 4:26 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:
update what? pharo ?
You can update Iceberg by executing: #('Iceberg-UI' 'Iceberg-Plugin' 'Iceberg-Metacello-Integration' 'Iceberg-Libgit' 'Iceberg' 'BaselineOfIceberg' 'LibGit-Core' 'BaselineOfLibGit') do: [ :each | each asPackage removeFromSystem ]. Metacello new baseline: 'Iceberg'; repository: 'github://pharo-vcs/iceberg:dev-0.5'; load. -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
2017-09-01 16:29 GMT+02:00 Cyril Ferlicot <cyril.ferlicot@gmail.com>:
On Fri, Sep 1, 2017 at 4:26 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:
update what? pharo ?
You can update Iceberg by executing:
#('Iceberg-UI' 'Iceberg-Plugin' 'Iceberg-Metacello-Integration' 'Iceberg-Libgit' 'Iceberg' 'BaselineOfIceberg' 'LibGit-Core' 'BaselineOfLibGit') do: [ :each | each asPackage removeFromSystem ].
Metacello new baseline: 'Iceberg'; repository: 'github://pharo-vcs/iceberg:dev-0.5'; load.
Ah, thanks. I will try it out and report back if the crashes still occur.
-- Cyril Ferlicot https://ferlicot.fr
http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
2017-09-01 16:48 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com>:
2017-09-01 16:29 GMT+02:00 Cyril Ferlicot <cyril.ferlicot@gmail.com>:
On Fri, Sep 1, 2017 at 4:26 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:
update what? pharo ?
You can update Iceberg by executing:
#('Iceberg-UI' 'Iceberg-Plugin' 'Iceberg-Metacello-Integration' 'Iceberg-Libgit' 'Iceberg' 'BaselineOfIceberg' 'LibGit-Core' 'BaselineOfLibGit') do: [ :each | each asPackage removeFromSystem ].
Metacello new baseline: 'Iceberg'; repository: 'github://pharo-vcs/iceberg:dev-0.5'; load.
Ah, thanks. I will try it out and report back if the crashes still occur.
Oh no! Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :( I reenabled the setting "Include system repositories by default", but still, the window is empty: [image: Inline-Bild 1] How can I get back the system repository ?
-- Cyril Ferlicot https://ferlicot.fr
http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
[image: Inline-Bild 1]
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory. -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
2017-09-01 17:06 GMT+02:00 Cyril Ferlicot <cyril.ferlicot@gmail.com>:
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
[image: Inline-Bild 1]
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory.
yes, seems to work.
-- Cyril Ferlicot https://ferlicot.fr
http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
2017-09-01 17:09 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com>:
2017-09-01 17:06 GMT+02:00 Cyril Ferlicot <cyril.ferlicot@gmail.com>:
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
[image: Inline-Bild 1]
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory.
yes, seems to work.
But, is the GitHub -> Review pull requests .... menu entry gone? I can not find it anymore.
-- Cyril Ferlicot https://ferlicot.fr
http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
On 1 Sep 2017, at 17:19, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 17:09 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>>:
2017-09-01 17:06 GMT+02:00 Cyril Ferlicot <cyril.ferlicot@gmail.com <mailto:cyril.ferlicot@gmail.com>>:
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>> wrote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
<grafik.png>
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory.
yes, seems to work.
But, is the
GitHub -> Review pull requests ....
menu entry gone? I can not find it anymore.
nope. somehow something went really bad with your update. anyway, it will not solve the crash problem, I just reproduced it (is just random⦠which makes it worst) Esteban
-- Cyril Ferlicot https://ferlicot.fr <https://ferlicot.fr/>
http://www.synectique.eu <http://www.synectique.eu/> 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
On 1 Sep 2017, at 17:06, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>> wrote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
<grafik.png>
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory.
mmm no. Better: IceCommitInfo allInstances anyOne repository register. (assuming anyOne will answer a pharo package) Esteban
-- Cyril Ferlicot https://ferlicot.fr <https://ferlicot.fr/>
http://www.synectique.eu <http://www.synectique.eu/> 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
2017-09-01 17:11 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 17:06, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
<grafik.png>
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory.
mmm no. Better:
IceCommitInfo allInstances anyOne repository register.
(assuming anyOne will answer a pharo package)
hm, no. "IceCommitInfo allInstances" is empty.
Esteban
-- Cyril Ferlicot https://ferlicot.fr
http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
On 1 Sep 2017, at 17:18, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 17:11 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com <mailto:estebanlm@gmail.com>>:
On 1 Sep 2017, at 17:06, Cyril Ferlicot <cyril.ferlicot@gmail.com <mailto:cyril.ferlicot@gmail.com>> wrote:
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>> wrote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
<grafik.png>
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory.
mmm no. Better:
IceCommitInfo allInstances anyOne repository register.
(assuming anyOne will answer a pharo package)
hm, no.
"IceCommitInfo allInstances" is empty.
weird⦠using 6.1?
Esteban
-- Cyril Ferlicot https://ferlicot.fr <https://ferlicot.fr/>
http://www.synectique.eu <http://www.synectique.eu/> 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
2017-09-01 17:44 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 17:18, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 17:11 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 17:06, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com> w rote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
<grafik.png>
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory.
mmm no. Better:
IceCommitInfo allInstances anyOne repository register.
(assuming anyOne will answer a pharo package)
hm, no.
"IceCommitInfo allInstances" is empty.
weird⦠using 6.1?
no, should I ? I loaded the latest pharo 7 (or is it the same as 6.1?) (get.pharo.org/70+vm)
Esteban
-- Cyril Ferlicot https://ferlicot.fr
http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
On 1 Sep 2017, at 17:47, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 17:44 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com <mailto:estebanlm@gmail.com>>:
On 1 Sep 2017, at 17:18, Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>> wrote:
2017-09-01 17:11 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com <mailto:estebanlm@gmail.com>>:
On 1 Sep 2017, at 17:06, Cyril Ferlicot <cyril.ferlicot@gmail.com <mailto:cyril.ferlicot@gmail.com>> wrote:
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>> wrote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
<grafik.png>
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory.
mmm no. Better:
IceCommitInfo allInstances anyOne repository register.
(assuming anyOne will answer a pharo package)
hm, no.
"IceCommitInfo allInstances" is empty.
weird⦠using 6.1?
no, should I ? I loaded the latest pharo 7 (or is it the same as 6.1?) (get.pharo.org/70+vm <http://get.pharo.org/70+vm>)
no, is ok⦠in fact what happened is that unloading iceberg removed the instances of IceCommitInfo so, I do not think this is a valid way to update on 7.0⦠easier is just to clone iceberg (with iceberg) and update it as any other project. Esteban
Esteban
-- Cyril Ferlicot https://ferlicot.fr <https://ferlicot.fr/>
http://www.synectique.eu <http://www.synectique.eu/> 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
How? On Fri, Sep 1, 2017 at 5:56 PM, Esteban Lorenzano <estebanlm@gmail.com> wrote:
On 1 Sep 2017, at 17:47, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 17:44 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 17:18, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 17:11 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 17:06, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
On Fri, Sep 1, 2017 at 5:04 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:
Oh no!
Now iceberg shows an empty list. Where is the pharo repository gone ? It took me a week to be at this point :(
I reenabled the setting "Include system repositories by default", but still, the window is empty:
<grafik.png>
How can I get back the system repository ?
I'm not 100% sure but I think you just need to click on "add local repository", point the pharo clone and add src as subdirectory.
mmm no. Better:
IceCommitInfo allInstances anyOne repository register.
(assuming anyOne will answer a pharo package)
hm, no.
"IceCommitInfo allInstances" is empty.
weird⦠using 6.1?
no, should I ? I loaded the latest pharo 7 (or is it the same as 6.1?) (get.pharo.org/70+vm)
no, is ok⦠in fact what happened is that unloading iceberg removed the instances of IceCommitInfo so, I do not think this is a valid way to update on 7.0⦠easier is just to clone iceberg (with iceberg) and update it as any other project.
Esteban
Esteban
-- Cyril Ferlicot https://ferlicot.fr
http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
2017-09-01 16:02 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 15:50, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 15:03 GMT+02:00 Esteban Lorenzano <estebanlm@gmail.com>:
On 1 Sep 2017, at 14:51, Nicolai Hess <nicolaihess@gmail.com> wrote:
2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com>:
When reviewing a pull request, I see this in the changes view: The tab title says "left working copy / right incoming update" but the code on the right side is what is current in my image
<grafik.png>
And I don't think "working copy" is the correct naming, as this view lets me diff changes within that history, so it may be that none of this code is actually in my "working copy", no ?
BTW, this is extremly unstable, reviewing a pull request, crashes a lot (the vm)
on windows?
Yes,
attached a another crash.dmp (maybe it helps)
<crash.dmp>
can you tell me the PR you were analysing ?
https://api.github.com/repos/pharo-project/pharo/pulls/237
Esteban
2017-09-01 14:48 GMT+02:00 Nicolai Hess <nicolaihess@gmail.com>:
When reviewing a pull request, I see this in the changes view: The tab title says "left working copy / right incoming update" but the code on the right side is what is current in my image
[image: Inline-Bild 1]
And I don't think "working copy" is the correct naming, as this view lets me diff changes within that history, so it may be that none of this code is actually in my "working copy", no ?
And how do I know if a pull request / change is already included ? I looked at a pull request and it seems this change is already in my image (a fresh image from 30.08 (Pharo7.0alpha.build.78.sha.35c21c3fac9b557eb38ec569fbbb109f2015c71a) The pull request (https://api.github.com/repos/pharo-project/pharo/pulls/231) is "open", but I can see the new code already in my image. The diff view tells me, that the method UITheme>>warningTextColor changes from warningTextColor ^ Color yellow muchDarker to warningTextColor ^ Color yellow But the method in the image already looks like this: warningTextColor ^ Color yellow
On Fri, Sep 1, 2017 at 4:46 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:
And how do I know if a pull request / change is already included ?
I looked at a pull request and it seems this change is already in my image (a fresh image from 30.08 (Pharo7.0alpha.build.78.sha.35c21c3fac9b557eb38ec569fbbb109f2015c71a) The pull request (https://api.github.com/repos/ pharo-project/pharo/pulls/231) is "open", but I can see the new code already in my image.
The diff view tells me, that the method UITheme>>warningTextColor changes from
warningTextColor ^ Color yellow muchDarker
to
warningTextColor ^ Color yellow
But the method in the image already looks like this:
warningTextColor ^ Color yellow
The *old* implementation is warningTextColor ^ Color yellow and the *new* implementation is warningTextColor ^ Color yellow muchDarker (See https://github.com/pharo-project/pharo/pull/231/files) So, the diff may be inversed. (I did not checked) -- Cyril Ferlicot https://ferlicot.fr http://www.synectique.eu 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
On 1 Sep 2017, at 16:50, Cyril Ferlicot <cyril.ferlicot@gmail.com> wrote:
On Fri, Sep 1, 2017 at 4:46 PM, Nicolai Hess <nicolaihess@gmail.com <mailto:nicolaihess@gmail.com>> wrote:
And how do I know if a pull request / change is already included ?
I looked at a pull request and it seems this change is already in my image (a fresh image from 30.08 (Pharo7.0alpha.build.78.sha.35c21c3fac9b557eb38ec569fbbb109f2015c71a) The pull request (https://api.github.com/repos/pharo-project/pharo/pulls/231 <https://api.github.com/repos/pharo-project/pharo/pulls/231>) is "open", but I can see the new code already in my image.
The diff view tells me, that the method UITheme>>warningTextColor changes from
warningTextColor ^ Color yellow muchDarker
to
warningTextColor ^ Color yellow
But the method in the image already looks like this:
warningTextColor ^ Color yellow
The *old* implementation is
warningTextColor ^ Color yellow
and the *new* implementation is
warningTextColor ^ Color yellow muchDarker
(See https://github.com/pharo-project/pharo/pull/231/files <https://github.com/pharo-project/pharo/pull/231/files>)
So, the diff may be inversed. (I did not checked)
yep. Damn it :) Esteban
-- Cyril Ferlicot https://ferlicot.fr <https://ferlicot.fr/>
http://www.synectique.eu <http://www.synectique.eu/> 2 rue Jacques Prévert 01, 59650 Villeneuve d'ascq France
participants (4)
-
Cyril Ferlicot -
Esteban Lorenzano -
Nicolai Hess -
Stephane Ducasse