On Fri, Sep 1, 2017 at 4:46 PM, Nicolai Hess <nicolaihess@gmail.com> wrote:


And how do I know if a pull request / change is already included ?

I looked at a pull request
and it seems this change is already in my image (a fresh image from 30.08 (Pharo7.0alpha.build.78.sha.35c21c3fac9b557eb38ec569fbbb109f2015c71a)
The pull request (https://api.github.com/repos/pharo-project/pharo/pulls/231) is�� "open", but I can see the new code already in my image.

The diff view tells me, that the method
UITheme>>warningTextColor changes from

warningTextColor
������ ^ Color yellow muchDarker

to

warningTextColor
������ ^ Color yellow

But the method in the image already looks like this:

warningTextColor
������ ^ Color yellow
��


The *old* implementation is

warningTextColor
�� ^ Color yellow

and the *new* implementation is

warningTextColor
�� ^ Color yellow muchDarker

(See��https://github.com/pharo-project/pharo/pull/231/files)

So, the diff may be inversed. (I did not checked)


--
Cyril Ferlicot
https://ferlicot.fr

http://www.synectique.eu
2 rue Jacques Pr��vert 01,
59650 Villeneuve d'ascq France