Sean P. DeNigris wrote

* String>>displayProgressAt:from:to:during: has "deprecated" in the comment, but is not in a deprecated category. The timestamp is 9/7/11 which puts it either 1.2 or early 1.3, but either way, it should be removed for 2.0, right? There is only one sender in the image, which can easily be fixed to call #displayProgressFrom:to:during:

Steph, this one's yours, do you know why it was deprecated and why it was done in the comment instead of using deprecated:on:in:? Is wanting to place a progress bar in a specific location not ever needed? If not, we should remove it from all the UIManagers also, right? Thanks. Sean -- View this message in context: http://forum.world.st/Notify-progress-with-Announcements-instead-of-Exceptio... Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Holy crap, SystemProgressMorph's "instance creation" method doesn't return an instance at all but a block. I really wish I understood this design decision before I try to cut all this out. Yikes, check out SystemProgressMorph>>label:min:max: label: shortDescription min: startMinValue max: startMaxValue "Answer the block that updates the progress bar." "some fun stuff added (by kph) - bar value: #label. - tell me my current label. - bar value: 'newLabel'. - enable changing the label from within the workBlock - bar value: #increment. - enable progress by one without keeping a counter - bar value: #decrement. - go backwards (if you really have to, useful for an abort, or rollback)! - bar value: newBigNum. - change the max on the fly - when you find there is more to do. - bar value: (bar value: #setMax) + 20 - change the max on the fly - when you find there is more/less to do. - bar value: (bar value: #setMin) - 20 - change the min on the fly - not sure why you would want to. " | slot range barSize lastRefresh maxValue minValue bar| maxValue := startMaxValue. minValue := startMinValue. ((range := maxValue - minValue) <= 0 or: [(slot := self nextSlotFor: shortDescription) = 0]) ifTrue: [^[:barVal| 0 ]]. self recenter. self openInWorld. barSize := -1. "Enforces a inital draw of the morph" lastRefresh := Time millisecondClockValue. bar := bars at: slot. ^[:barValArg | | barVal return newBarSize | barVal := barValArg. return := nil. bar := bars at: slot. "new fun stuff here" barVal == #current ifTrue: [ return := barSize ]. barVal == #label ifTrue:[ return := (labels at: slot) contents ]. barVal == #setMax ifTrue: [ return := maxValue. maxValue := minValue ]. barVal == #setMin ifTrue: [ return := minValue. minValue := maxValue ]. barVal == #increment ifTrue: [return := barVal := barSize + 1]. barVal == #decrement ifTrue: [ return := barVal := barSize - 1]. (barVal isString and: [barVal isSymbol not]) ifTrue: [ (labels at: slot) contents: barVal. barVal := #refresh]. barVal == #refresh ifTrue: [self currentWorld displayWorld. return := true]. (barVal == SmallInteger maxVal or: [ barVal == #finished ]) ifTrue: [return := slot]. return ifNil: [ barVal > maxValue ifTrue: [return := maxValue := barVal]. barVal < minValue ifTrue: [return := minValue := barVal]. (barVal between: minValue and: maxValue) ifTrue: [newBarSize := (barVal - minValue / range * BarWidth) truncated. newBarSize = barSize ifFalse: [barSize := newBarSize. (Time millisecondsSince: lastRefresh) > 25 ifTrue: [barVal := #refresh ]]]. barVal == #refresh ifTrue: [ ((bar valueOfProperty: #useStripes) ifNil: [false]) ifTrue: [bar fillStyle origin: bar position - ((Time millisecondClockValue // 50 \\ 30) @ 0)]. bar barSize: barSize. self currentWorld displayWorld. lastRefresh := Time millisecondClockValue]]. return] -- View this message in context: http://forum.world.st/Notify-progress-with-Announcements-instead-of-Exceptio... Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

Sean P. DeNigris wrote

[:barValArg | | barVal return newBarSize | barVal := barValArg. return := nil. ... "new fun stuff here" barVal == #current ifTrue: [ return := barSize ]. barVal == #label ifTrue:[ return := (labels at: slot) contents ]. barVal == #setMax ifTrue: [ return := maxValue. maxValue := minValue ]. barVal == #setMin ifTrue: [ return := minValue. minValue := maxValue ]. barVal == #increment ifTrue: [return := barVal := barSize + 1]. barVal == #decrement ifTrue: [ return := barVal := barSize - 1]. (barVal isString and: [barVal isSymbol not]) ifTrue: [ (labels at: slot) contents: barVal. barVal := #refresh]. barVal == #refresh ifTrue: [self currentWorld displayWorld. return := true]. ... return]

I think we should consider this alternate Class implementation. A block with its own custom method lookup mechanism ;-) -- View this message in context: http://forum.world.st/Notify-progress-with-Announcements-instead-of-Exceptio... Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

And I cleaned it removing broken options :) In essence this is a dsl built using functional programming style. Would be better to have an object :) On May 14, 2012, at 4:56 PM, Sean P. DeNigris wrote:

Holy crap, SystemProgressMorph's "instance creation" method doesn't return an instance at all but a block. I really wish I understood this design decision before I try to cut all this out. Yikes, check out SystemProgressMorph>>label:min:max:

label: shortDescription min: startMinValue max: startMaxValue "Answer the block that updates the progress bar."

"some fun stuff added (by kph)

- bar value: #label. - tell me my current label. - bar value: 'newLabel'. - enable changing the label from within the workBlock - bar value: #increment. - enable progress by one without keeping a counter - bar value: #decrement. - go backwards (if you really have to, useful for an abort, or rollback)!

- bar value: newBigNum. - change the max on the fly - when you find there is more to do. - bar value: (bar value: #setMax) + 20 - change the max on the fly - when you find there is more/less to do. - bar value: (bar value: #setMin) - 20 - change the min on the fly - not sure why you would want to. " | slot range barSize lastRefresh maxValue minValue bar| maxValue := startMaxValue. minValue := startMinValue. ((range := maxValue - minValue) <= 0 or: [(slot := self nextSlotFor: shortDescription) = 0]) ifTrue: [^[:barVal| 0 ]]. self recenter. self openInWorld. barSize := -1. "Enforces a inital draw of the morph" lastRefresh := Time millisecondClockValue. bar := bars at: slot. ^[:barValArg | | barVal return newBarSize | barVal := barValArg. return := nil. bar := bars at: slot. "new fun stuff here" barVal == #current ifTrue: [ return := barSize ]. barVal == #label ifTrue:[ return := (labels at: slot) contents ]. barVal == #setMax ifTrue: [ return := maxValue. maxValue := minValue ]. barVal == #setMin ifTrue: [ return := minValue. minValue := maxValue ]. barVal == #increment ifTrue: [return := barVal := barSize + 1]. barVal == #decrement ifTrue: [ return := barVal := barSize - 1]. (barVal isString and: [barVal isSymbol not]) ifTrue: [ (labels at: slot) contents: barVal. barVal := #refresh]. barVal == #refresh ifTrue: [self currentWorld displayWorld. return := true]. (barVal == SmallInteger maxVal or: [ barVal == #finished ]) ifTrue: [return := slot]. return ifNil: [ barVal > maxValue ifTrue: [return := maxValue := barVal]. barVal < minValue ifTrue: [return := minValue := barVal]. (barVal between: minValue and: maxValue) ifTrue: [newBarSize := (barVal - minValue / range * BarWidth) truncated. newBarSize = barSize ifFalse: [barSize := newBarSize. (Time millisecondsSince: lastRefresh) > 25 ifTrue: [barVal := #refresh ]]]. barVal == #refresh ifTrue: [ ((bar valueOfProperty: #useStripes) ifNil: [false]) ifTrue: [bar fillStyle origin: bar position - ((Time millisecondClockValue // 50 \\ 30) @ 0)]. bar barSize: barSize. self currentWorld displayWorld. lastRefresh := Time millisecondClockValue]]. return]

-- View this message in context: http://forum.world.st/Notify-progress-with-Announcements-instead-of-Exceptio... Sent from the Pharo Smalltalk mailing list archive at Nabble.com.

I have a few questions about displaying progress... 1. What's the best way to do something like the following: I may be in the UI thread. I want to process a loop in a background thread, but block my current execution path, while still letting the world update. This is my use case... NewSystemProgressMorph>>show: aString from: startNumber to: endNumber during: aBlock | progressMorph | progressMorph := self addItemShowing: aString from: startNumber to: endNumber. self recenter. self openInWorld. [ [ progressMorph do: aBlock ] ensure: [ self close: progressMorph ] ] fork. [ progressMorph hasResult ] whileFalse: [ self currentWorld displayWorld. (Delay forMilliseconds: 20) wait ]. ^ progressMorph result I kept the #displayWorld from the old SystemProgressMorph, but it feels like a hack. I can't rely on stepping because I have to block until result is returned. "progressMorph do: aBlock" sets result, protected by a critical section of a Semaphore (I don't know if that's right/safe, just cobbled it together from the old implementation and a little googling). 2. what morphic messages from a non-UI thread have to be wrapped in addDeferredUIMessage:? #delete? repositioning a Morph? Is it any message sent to a morph, or only particular ones. 3. If anyone's using the following SystemProgressMorph functionality, please speak up. It seems overcomplicated and may disappear very soon :) value: newBigNum. - change the max on the fly - when you find there is more to do. bar value: (bar value: #setMax) + 20 - change the max on the fly - when you find there is more/less to do. bar value: (bar value: #setMin) - 20 - change the min on the fly - not sure why you would want to. -- View this message in context: http://forum.world.st/Notify-progress-with-Announcements-instead-of-Exceptio... Sent from the Pharo Smalltalk mailing list archive at Nabble.com.