[ENH]: Window Menu Registration (like World Menu)
https://pharo.fogbugz.com/f/cases/10910/Window-Menu-Registration-like-World-... Fix in inbox: SLICE-Issue-10910-Window-Menu-Registration-like-World-Menu-SeanDeNigris.1 Issue 10910: Window Menu Registration (like World Menu) * Use annotation <windowMenu> * Re-implement existing menu options with pragma/builder * Refactor general menu discovery code common to both World and Window menus I forgot to put it in the commit message, but I also removed PasteUpMorph>>discoveredMenu & all implementations of #discoveredWorldMenuAt: and #worldMenuAt:. There were no senders in the image and they don't seem particularly useful... ----- Cheers, Sean -- View this message in context: http://forum.world.st/ENH-Window-Menu-Registration-like-World-Menu-tp4693269... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Sean P. DeNigris wrote > https://pharo.fogbugz.com/f/cases/10910/Window-Menu-Registration-like-World-Menu New fix in inbox: SLICE-Issue-10910-Window-Menu-Registration-like-World-Menu-SeanDeNigris.3 This version: * FallbackMenu: reset the builder after debugging, or the fallback menu does not appear anymore (e.g. the next time the pragma menu tries to build itself) >From version 2: * Remove DiscoveredMenu * Move most menu building logic into PragmaMenuBuilder. Now we have fallback menus for all buildl menus! e.g. Nautilus menus * Leave a #fallbackMenuOn: hook in Object (packaged with PragmaMenuBuilder), where custom fallback items can be added. I didn't want to do it with pragmas in case we ended up with neither the discovered or fallback working * Class comment for FallbackMenu. Thanks Cami for the review :) * PragmaMenuBuilder - don't #buildTree during instance creation. Wait until necessary (i.e. when a menu spec is built). This makes it nice and clean to trap all errors when the spec is built and throw up a fallback menu >From version 1: * Use annotation <windowMenu> * Re-implement existing menu options with pragma/builder * Refactor general menu discovery code common to both World and Window menus ----- Cheers, Sean -- View this message in context: http://forum.world.st/ENH-Window-Menu-Registration-like-World-Menu-tp4693269p4693705.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Nobody has looked at this in 10 days... On Jun 17, 2013, at 2:12 PM, "Sean P. DeNigris" <sean@clipperadams.com> wrote:
Sean P. DeNigris wrote
https://pharo.fogbugz.com/f/cases/10910/Window-Menu-Registration-like-World-...
New fix in inbox: SLICE-Issue-10910-Window-Menu-Registration-like-World-Menu-SeanDeNigris.3
This version: * FallbackMenu: reset the builder after debugging, or the fallback menu does not appear anymore (e.g. the next time the pragma menu tries to build itself)
From version 2: * Remove DiscoveredMenu * Move most menu building logic into PragmaMenuBuilder. Now we have fallback menus for all buildl menus! e.g. Nautilus menus * Leave a #fallbackMenuOn: hook in Object (packaged with PragmaMenuBuilder), where custom fallback items can be added. I didn't want to do it with pragmas in case we ended up with neither the discovered or fallback working * Class comment for FallbackMenu. Thanks Cami for the review :) * PragmaMenuBuilder - don't #buildTree during instance creation. Wait until necessary (i.e. when a menu spec is built). This makes it nice and clean to trap all errors when the spec is built and throw up a fallback menu
From version 1: * Use annotation <windowMenu> * Re-implement existing menu options with pragma/builder * Refactor general menu discovery code common to both World and Window menus
----- Cheers, Sean -- View this message in context: http://forum.world.st/ENH-Window-Menu-Registration-like-World-Menu-tp4693269... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
yes because we are busy. Busy does not mean that we are not interested.
Nobody has looked at this in 10 days...
On Jun 17, 2013, at 2:12 PM, "Sean P. DeNigris" <sean@clipperadams.com> wrote:
Sean P. DeNigris wrote
https://pharo.fogbugz.com/f/cases/10910/Window-Menu-Registration-like-World-...
New fix in inbox: SLICE-Issue-10910-Window-Menu-Registration-like-World-Menu-SeanDeNigris.3
This version: * FallbackMenu: reset the builder after debugging, or the fallback menu does not appear anymore (e.g. the next time the pragma menu tries to build itself)
From version 2: * Remove DiscoveredMenu * Move most menu building logic into PragmaMenuBuilder. Now we have fallback menus for all buildl menus! e.g. Nautilus menus * Leave a #fallbackMenuOn: hook in Object (packaged with PragmaMenuBuilder), where custom fallback items can be added. I didn't want to do it with pragmas in case we ended up with neither the discovered or fallback working * Class comment for FallbackMenu. Thanks Cami for the review :) * PragmaMenuBuilder - don't #buildTree during instance creation. Wait until necessary (i.e. when a menu spec is built). This makes it nice and clean to trap all errors when the spec is built and throw up a fallback menu
From version 1: * Use annotation <windowMenu> * Re-implement existing menu options with pragma/builder * Refactor general menu discovery code common to both World and Window menus
----- Cheers, Sean -- View this message in context: http://forum.world.st/ENH-Window-Menu-Registration-like-World-Menu-tp4693269... Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (3)
-
Marcus Denker -
Sean P. DeNigris -
Stéphane Ducasse