[Pharo-project] Issue 3682 in pharo: multiple undo/redo is broken in 1.2 because of Ocompletion.
Status: Accepted Owner: aplan...@gmail.com Labels: Milestone-1.2 New issue 3682 by aplan...@gmail.com: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 I've found the fix. It has two parts, one part for the core and the second is for ocompletion.
Updates: Status: Fixed Labels: Milestone-1.3 Comment #1 on issue 3682 by aplan...@gmail.com: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 Fix for the core 1.2 and 1.3 (so a .cs is attached) Attachments: selectInvisiblyAt.2.cs 394 bytes
Updates: Labels: -Milestone-1.3 Comment #2 on issue 3682 by aplan...@gmail.com: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 Fix for Ocompletion in 1.2 (.cs is attached) *** warning *** be sure that the core is fixed before loading this Ocompletion fix. Attachments: ocompletion-selectPosition.1.cs 511 bytes
Comment #3 on issue 3682 by stephane...@gmail.com: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 Ok I integrated selectInvisibilityAt in 13042
Comment #4 on issue 3682 by stephane...@gmail.com: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 what is strnage is that we do not have a caret method in 1.3
Comment #5 on issue 3682 by marcus.d...@gmail.com: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 it's an extension method of ocompletion, I think (or shout?)
Comment #6 on issue 3682 by aplan...@gmail.com: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 yes, I think that all ocompletion extension methods in SmalltalkEditor should be integrated in the core. as an example, #caret should be in TextEditor and rewritten to simply return startIndex. selectInvisibilityAt should also be in 1.2 core so that the ocompletion fix becomes loadable in 1.2
Comment #7 on issue 3682 by Torsten....@astares.de: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 #caret? Does it return the caret itself or the #caretPosition? If so we should rename it.
Comment #8 on issue 3682 by aplan...@gmail.com: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 yes it returns the index of the caret, caretPosition, caretIndex...
Updates: Status: Closed Comment #9 on issue 3682 by stephane...@gmail.com: multiple undo/redo is broken in 1.2 because of Ocompletion. http://code.google.com/p/pharo/issues/detail?id=3682 part two in 13045 and in 12333
participants (1)
-
pharo＠googlecode.com