I wanted to add as an extension method to the Sound package: Job>>#beepAtEnd "Sound must first be enabled via `SoundSystem soundEnabled: true.`" self announcer when: JobEnd do: [ SoundSystem current beep ] I figured I'd get some feedback first since I know we're trying to reduce dependencies... ----- Cheers, Sean -- View this message in context: http://forum.world.st/Can-Sound-depend-on-Jobs-tp4914083.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Do you mean that job depends on sound? I think it should not. Can't that be an extension of yours? (in a method extension, in a separate package)? Guille -------- Original Message --------
I wanted to add as an extension method to the Sound package: Job>>#beepAtEnd "Sound must first be enabled via `SoundSystem soundEnabled: true.`"
self announcer when: JobEnd do: [ SoundSystem current beep ]
I figured I'd get some feedback first since I know we're trying to reduce dependencies...
----- Cheers, Sean -- View this message in context: http://forum.world.st/Can-Sound-depend-on-Jobs-tp4914083.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
The questions we should ask ourselves always: - Would it make sense to use Sound without Jobs? - Would it make sense to use Jobs without Sound? First, I just want to say I do not have the answer to that question because I do not know those packages very well. Butttt.... it's smelly to me. My reflex is to put that as a third package. Second and more meta, I think we should ask ourselves those questions more often (just like Sean did, thanks Sean! :D). -------- Original Message --------
2016-09-05 9:55 GMT+02:00 Guille Polito <guillermopolito@gmail.com <mailto:guillermopolito@gmail.com>>:
Do you mean that job depends on sound?
I guess Sean wants put #beepAtEnd to Sound packageas Job extension. Is such dependency valid?
Guille Polito wrote
The questions we should ask ourselves always:
Yes to both, so it seems a third package (with only one method in it!) is in order. Thanks for helping me think this through! ----- Cheers, Sean -- View this message in context: http://forum.world.st/Can-Sound-depend-on-Jobs-tp4914083p4914185.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
Sean P. DeNigris wrote
it seems a third package (with only one method in it!) is in order.
Any ideas on where to commit the JobsSound package? ----- Cheers, Sean -- View this message in context: http://forum.world.st/Can-Sound-depend-on-Jobs-tp4914083p4914210.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
close to the sound package. Le 5/9/16 à 19:18, Sean P. DeNigris a écrit :
Sean P. DeNigris wrote
it seems a third package (with only one method in it!) is in order. Any ideas on where to commit the JobsSound package?
----- Cheers, Sean -- View this message in context: http://forum.world.st/Can-Sound-depend-on-Jobs-tp4914083p4914210.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.
participants (4)
-
Denis Kudriashov -
Guille Polito -
Sean P. DeNigris -
stepharo