[pharo-project/pharo-core] fa9d41: 30742
Branch: refs/heads/3.0 Home: https://github.com/pharo-project/pharo-core Commit: fa9d4152ac7e73ad7ec77cc2f34d721299b952fb https://github.com/pharo-project/pharo-core/commit/fa9d4152ac7e73ad7ec77cc2f... Author: Jenkins Build Server <board@pharo-project.org> Date: 2014-02-04 (Tue, 04 Feb 2014) Changed paths: M AST-Interpreter-Test.package/ASTCacheTest.class/README.md M AST-Interpreter-Test.package/ASTInterpreterTest.class/README.md M AST-Interpreter-Test.package/ASTStackMappingTest.class/README.md M AST-Interpreter-Test.package/InterpreterTest.class/README.md M AST-Tests-Core.package/RBFormatterTests.class/README.md M AST-Tests-Core.package/RBParserTest.class/README.md M AST-Tests-Core.package/RBProgramNodeTest.class/README.md M AST-Tests-Core.package/RBScannerTest.class/README.md M FreeType.package/FT2MemoryFaceData.class/README.md M FreeType.package/FontFamilyAbstract.class/README.md M FreeType.package/FontFamilyMemberAbstract.class/README.md M FreeType.package/FreeTypeCache.class/README.md M FreeType.package/FreeTypeCacheConstants.class/README.md M FreeType.package/FreeTypeCacheEntry.class/README.md M FreeType.package/FreeTypeCacheLinkedList.class/README.md M FreeType.package/FreeTypeEmbeddedFileInfo.class/README.md M FreeType.package/FreeTypeExternalMemory.class/README.md M FreeType.package/FreeTypeFace.class/README.md M FreeType.package/FreeTypeFileInfo.class/README.md M FreeType.package/FreeTypeFileInfoAbstract.class/README.md M FreeType.package/FreeTypeFont.class/README.md M FreeType.package/FreeTypeFontFamily.class/README.md M FreeType.package/FreeTypeFontFamilyMember.class/README.md M FreeType.package/FreeTypeNameParser.class/README.md M FreeType.package/FreeTypeSettings.class/README.md M FreeType.package/FreeTypeSubPixelAntiAliasedGlyphRenderer.class/README.md M FreeType.package/GlyphForm.class/README.md M FreeType.package/TextStyleAsFontFamily.class/README.md M FreeType.package/TextStyleAsFontFamilyMember.class/README.md M FreeTypeTests.package/FreeTypeCacheTest.class/README.md R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/setUp.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testConstants.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testEntriesRemovedFIFO.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testFailedGet.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testFreeTypeCacheEntry.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testInstanceInitialization.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testMaximumSizeRespectedOnIfAbsentPut.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testMaximumSizeRespectedOnPut.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testNormalGetIfAbsentPut.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testNormalGetIfAbsentPutTwice.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testNormalGetIfAbsentPutTwiceIntoNonEmptyCache.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testNormalPutGet.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testNormalPutGetTwice.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testNormalPutGetWidth.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testPutSameElementTwice.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testRemoveAll.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testRemoveAllForFont.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testRemoveAllForType.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testReport.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testSetMaximumSize.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testSetMaximumSizeGrow.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testSetMaximumSizeShrink.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testSetMaximumSizeUnbounded.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/testSingleton.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/validateCollections_.st R FreeTypeTests.package/FreeTypeCacheTest.class/instance/as yet unclassified/validateSizes_.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/private/validateCollections_.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/private/validateSizes_.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/running/setUp.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testConstants.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testEntriesRemovedFIFO.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testFailedGet.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testFreeTypeCacheEntry.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testInstanceInitialization.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testMaximumSizeRespectedOnIfAbsentPut.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testMaximumSizeRespectedOnPut.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testNormalGetIfAbsentPut.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testNormalGetIfAbsentPutTwice.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testNormalGetIfAbsentPutTwiceIntoNonEmptyCache.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testNormalPutGet.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testNormalPutGetTwice.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testNormalPutGetWidth.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testPutSameElementTwice.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testRemoveAll.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testRemoveAllForFont.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testRemoveAllForType.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testReport.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testSetMaximumSize.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testSetMaximumSizeGrow.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testSetMaximumSizeShrink.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testSetMaximumSizeUnbounded.st A FreeTypeTests.package/FreeTypeCacheTest.class/instance/tests/testSingleton.st M GroupManager.package/AGroupHasBeenAdded.class/README.md M GroupManager.package/AGroupHasBeenCreated.class/README.md M GroupManager.package/AGroupHasBeenRegistered.class/README.md M GroupManager.package/AGroupHasBeenRemoved.class/README.md M GroupManager.package/AGroupHasBeenRenamed.class/README.md M GroupManager.package/AGroupHasBeenUnregistered.class/README.md M GroupManager.package/AbstractGroupAnnouncement.class/README.md M GroupManager.package/GroupAnnouncer.class/README.md M GroupManagerUI.package/DialogGroupAdder.class/README.md M GroupManagerUI.package/DialogGroupAdderUI.class/README.md M GroupManagerUI.package/DialogGroupManager.class/README.md M GroupManagerUI.package/DialogGroupManagerUI.class/README.md M GroupManagerUI.package/GroupCreatorTreeModel.class/README.md M GroupManagerUI.package/GroupNode.class/README.md M GroupManagerUI.package/ItemNode.class/README.md M Kernel.package/Abort.class/README.md M Kernel.package/ClassCommentReader.class/README.md M Kernel.package/RelativeInstructionPrinter.class/README.md M Kernel.package/SimulationExceptionWrapper.class/README.md M Kernel.package/SimulationGuardException.class/README.md M Kernel.package/WeakActionSequence.class/README.md A ScriptLoader30.package/ScriptLoader.class/instance/pharo - scripts/script395.st A ScriptLoader30.package/ScriptLoader.class/instance/pharo - updates/update30742.st M ScriptLoader30.package/ScriptLoader.class/instance/public/commentForCurrentUpdate.st M Spec-Debugger.package/EyeDebuggerContextInspector.class/definition.st R Spec-Inspector.package/EyeContextInspector.class/README.md R Spec-Inspector.package/EyeContextInspector.class/class/accessing/label.st R Spec-Inspector.package/EyeContextInspector.class/definition.st R Spec-Inspector.package/EyeContextInspector.class/instance/accessing/doItContext.st R Spec-Inspector.package/EyeContextInspector.class/instance/list/addVariableFields_.st R Spec-Inspector.package/EyeContextInspector.class/instance/list/tempNames.st A Spec-Inspector.package/EyeMethodContextInspector.class/README.md A Spec-Inspector.package/EyeMethodContextInspector.class/class/accessing/label.st A Spec-Inspector.package/EyeMethodContextInspector.class/definition.st A Spec-Inspector.package/EyeMethodContextInspector.class/instance/accessing/doItContext.st A Spec-Inspector.package/EyeMethodContextInspector.class/instance/list/addVariableFields_.st A Spec-Inspector.package/EyeMethodContextInspector.class/instance/list/tempNames.st M Spec-Inspector.package/extension/MethodContext/class/inspectorClass.st M Tools.package/DialogItemsChooser.class/README.md M Tools.package/FileListGrid.class/README.md M Tools.package/FileListGridNode.class/README.md M Tools.package/ImageCleaner.class/README.md M Tools.package/SourceWebBrowser.class/README.md M Tools.package/SpotlightShortcuts.class/README.md M Tools.package/ValueHolder.class/README.md M ToolsTest.package/AndreasSystemProfilerTest.class/README.md M ToolsTest.package/ArgumentNamesTest.class/README.md M ToolsTest.package/DebuggerTest.class/README.md M ToolsTest.package/DynamicMessageImplementorTest.class/README.md M ToolsTest.package/MessageTallyTest.class/README.md M ToolsTest.package/OpenToolTest.class/README.md M ToolsTest.package/PointerFinderTest.class/README.md M ToolsTest.package/WorkspaceTest.class/README.md M Traits.package/TApplyingOnClassSide.class/README.md M Traits.package/TBehavior.class/README.md M Traits.package/TBehaviorCategorization.class/README.md M Traits.package/TClass.class/README.md M Traits.package/TClassDescription.class/README.md M Traits.package/TComposingDescription.class/README.md M UpdateStreamer-Tests.package/UpdateStreamerTest.class/README.md Log Message: ----------- 30742 12794 Class comments missing in UpdateStreamer package https://pharo.fogbugz.com/f/cases/12794 12802 Class comments missing for Kernel package https://pharo.fogbugz.com/f/cases/12802 12804 Class comment missing in AST packages https://pharo.fogbugz.com/f/cases/12804 12797 Class comments missing for tools package https://pharo.fogbugz.com/f/cases/12797 12796 Class comments missing for Traits package https://pharo.fogbugz.com/f/cases/12796 12798 Class comments missing in GroupManager package https://pharo.fogbugz.com/f/cases/12798 12806 Class comment missing in package FreeType + categorizing for FreeTypeCacheTest https://pharo.fogbugz.com/f/cases/12806 12800 EyeContextInspector should be renamed to EyeMethodContextInspector https://pharo.fogbugz.com/f/cases/12800 http://files.pharo.org/image/30/30742.zip
Thanks for all these comments! On 05 Feb 2014, at 00:27, GitHub <noreply@github.com> wrote:
30742 12794 Class comments missing in UpdateStreamer package https://pharo.fogbugz.com/f/cases/12794
12802 Class comments missing for Kernel package https://pharo.fogbugz.com/f/cases/12802
12804 Class comment missing in AST packages https://pharo.fogbugz.com/f/cases/12804
12797 Class comments missing for tools package https://pharo.fogbugz.com/f/cases/12797
12796 Class comments missing for Traits package https://pharo.fogbugz.com/f/cases/12796
12798 Class comments missing in GroupManager package https://pharo.fogbugz.com/f/cases/12798
12806 Class comment missing in package FreeType + categorizing for FreeTypeCacheTest https://pharo.fogbugz.com/f/cases/12806
12800 EyeContextInspector should be renamed to EyeMethodContextInspector https://pharo.fogbugz.com/f/cases/12800
Still 1017 to go. Feel free to help: Â Â Â Smalltalk allClasses select: [:each | each comment includesSubstring: 'xxxx' ] Â External Package owners should also reintegrate too so these do not get lost when a new version of external packages get integrated. (for instance https://pharo.fogbugz.com/f/cases/12812 for Spec) step by step it goes ... Â Bye T. Â Gesendet:Â Mittwoch, 05. Februar 2014 um 08:36 Uhr Von:Â Pharo4Stef <pharo4Stef@free.fr> An:Â "Pharo Development List" <pharo-dev@lists.pharo.org> Betreff:Â [Pharo-dev] comments :) Thanks for all these comments! Â On 05 Feb 2014, at 00:27, GitHub <noreply@github.com> wrote:Â 30742 12794 Class comments missing in UpdateStreamer package https://pharo.fogbugz.com/f/cases/12794[https://pharo.fogbugz.com/f/cases/12794] 12802 Class comments missing for Kernel package https://pharo.fogbugz.com/f/cases/12802[https://pharo.fogbugz.com/f/cases/12802] 12804 Class comment missing in AST packages https://pharo.fogbugz.com/f/cases/12804[https://pharo.fogbugz.com/f/cases/12804] 12797 Class comments missing for tools package https://pharo.fogbugz.com/f/cases/12797[https://pharo.fogbugz.com/f/cases/12797] 12796 Class comments missing for Traits package https://pharo.fogbugz.com/f/cases/12796[https://pharo.fogbugz.com/f/cases/12796] 12798 Class comments missing in GroupManager package https://pharo.fogbugz.com/f/cases/12798[https://pharo.fogbugz.com/f/cases/12798] 12806 Class comment missing in package FreeType + categorizing for FreeTypeCacheTest https://pharo.fogbugz.com/f/cases/12806[https://pharo.fogbugz.com/f/cases/12806] 12800 EyeContextInspector should be renamed to EyeMethodContextInspector https://pharo.fogbugz.com/f/cases/12800[https://pharo.fogbugz.com/f/cases/12800]
Good work. Minor thing though - could they maybe grouped under one Case. I'd hate for someone to look at the massive amount work done for Pharo 3 indicated by the cases close and think "Its just lots of comment updates" Sure it would end up being a long running case - with a lot of slices (each based off the most recent image). You'd have to see how that panned out, and itf it got too long, just link to a new case for the next group. Or maybe there is some difficulty that I can't forsee. cheers -ben Torsten Bergmann wrote:
Still 1017 to go. Feel free to help:
Smalltalk allClasses select: [:each | each comment includesSubstring: 'xxxx' ]
External Package owners should also reintegrate too so these do not get lost when a new version of external packages get integrated. (for instance https://pharo.fogbugz.com/f/cases/12812 for Spec)
step by step it goes ...
Bye T.
Gesendet: Mittwoch, 05. Februar 2014 um 08:36 Uhr Von: Pharo4Stef <pharo4Stef@free.fr> An: "Pharo Development List" <pharo-dev@lists.pharo.org> Betreff: [Pharo-dev] comments :)
Thanks for all these comments!
On 05 Feb 2014, at 00:27, GitHub <noreply@github.com> wrote: 30742 12794 Class comments missing in UpdateStreamer package https://pharo.fogbugz.com/f/cases/12794[https://pharo.fogbugz.com/f/cases/12794]
12802 Class comments missing for Kernel package https://pharo.fogbugz.com/f/cases/12802[https://pharo.fogbugz.com/f/cases/12802]
12804 Class comment missing in AST packages https://pharo.fogbugz.com/f/cases/12804[https://pharo.fogbugz.com/f/cases/12804]
12797 Class comments missing for tools package https://pharo.fogbugz.com/f/cases/12797[https://pharo.fogbugz.com/f/cases/12797]
12796 Class comments missing for Traits package https://pharo.fogbugz.com/f/cases/12796[https://pharo.fogbugz.com/f/cases/12796]
12798 Class comments missing in GroupManager package https://pharo.fogbugz.com/f/cases/12798[https://pharo.fogbugz.com/f/cases/12798]
12806 Class comment missing in package FreeType + categorizing for FreeTypeCacheTest https://pharo.fogbugz.com/f/cases/12806[https://pharo.fogbugz.com/f/cases/12806]
12800 EyeContextInspector should be renamed to EyeMethodContextInspector https://pharo.fogbugz.com/f/cases/12800[https://pharo.fogbugz.com/f/cases/12800]
Hi Ben if we would just like to increase the number of cases/issues using a "case per class" would have been better. Adding final quality improvements (like docu) is usual before releases not only in the ST world. For the reasons: A single person can only do it step by step and therefore I used the granularity of projects/packages. This also helps reintegration /mergin back into external managed parts. There was no reaction onto my call for action from others. So instead of grumbling afterwards better use your keyboard to comment on classes ;) Thx T.
Gesendet: Donnerstag, 06. Februar 2014 um 10:43 Uhr Von: btc@openinworld.com An: "Pharo Development List" <pharo-dev@lists.pharo.org> Betreff: Re: [Pharo-dev] comments :)
Good work. Minor thing though - could they maybe grouped under one Case. I'd hate for someone to look at the massive amount work done for Pharo 3 indicated by the cases close and think "Its just lots of comment updates" Sure it would end up being a long running case - with a lot of slices (each based off the most recent image). You'd have to see how that panned out, and itf it got too long, just link to a new case for the next group. Or maybe there is some difficulty that I can't forsee. cheers -ben
Torsten Bergmann wrote:
Still 1017 to go. Feel free to help:
Smalltalk allClasses select: [:each | each comment includesSubstring: 'xxxx' ]
External Package owners should also reintegrate too so these do not get lost when a new version of external packages get integrated. (for instance https://pharo.fogbugz.com/f/cases/12812 for Spec)
step by step it goes ...
Bye T.
Gesendet: Mittwoch, 05. Februar 2014 um 08:36 Uhr Von: Pharo4Stef <pharo4Stef@free.fr> An: "Pharo Development List" <pharo-dev@lists.pharo.org> Betreff: [Pharo-dev] comments :)
Thanks for all these comments!
On 05 Feb 2014, at 00:27, GitHub <noreply@github.com> wrote: 30742 12794 Class comments missing in UpdateStreamer package https://pharo.fogbugz.com/f/cases/12794[https://pharo.fogbugz.com/f/cases/12794]
12802 Class comments missing for Kernel package https://pharo.fogbugz.com/f/cases/12802[https://pharo.fogbugz.com/f/cases/12802]
12804 Class comment missing in AST packages https://pharo.fogbugz.com/f/cases/12804[https://pharo.fogbugz.com/f/cases/12804]
12797 Class comments missing for tools package https://pharo.fogbugz.com/f/cases/12797[https://pharo.fogbugz.com/f/cases/12797]
12796 Class comments missing for Traits package https://pharo.fogbugz.com/f/cases/12796[https://pharo.fogbugz.com/f/cases/12796]
12798 Class comments missing in GroupManager package https://pharo.fogbugz.com/f/cases/12798[https://pharo.fogbugz.com/f/cases/12798]
12806 Class comment missing in package FreeType + categorizing for FreeTypeCacheTest https://pharo.fogbugz.com/f/cases/12806[https://pharo.fogbugz.com/f/cases/12806]
12800 EyeContextInspector should be renamed to EyeMethodContextInspector https://pharo.fogbugz.com/f/cases/12800[https://pharo.fogbugz.com/f/cases/12800]
How about using category "cleanup" instead of "bug"? And thank you for your work! nicolai 2014-02-06 11:16 GMT+01:00 Torsten Bergmann <astares@gmx.de>:
Hi Ben
if we would just like to increase the number of cases/issues using a "case per class" would have been better. Adding final quality improvements (like docu) is usual before releases not only in the ST world.
For the reasons: A single person can only do it step by step and therefore I used the granularity of projects/packages. This also helps reintegration /mergin back into external managed parts. There was no reaction onto my call for action from others.
So instead of grumbling afterwards better use your keyboard to comment on classes ;)
Thx T.
Gesendet: Donnerstag, 06. Februar 2014 um 10:43 Uhr Von: btc@openinworld.com An: "Pharo Development List" <pharo-dev@lists.pharo.org> Betreff: Re: [Pharo-dev] comments :)
Good work. Minor thing though - could they maybe grouped under one Case. I'd hate for someone to look at the massive amount work done for Pharo 3 indicated by the cases close and think "Its just lots of comment updates" Sure it would end up being a long running case - with a lot of slices (each based off the most recent image). You'd have to see how that panned out, and itf it got too long, just link to a new case for the next group. Or maybe there is some difficulty that I can't forsee. cheers -ben
Torsten Bergmann wrote:
Still 1017 to go. Feel free to help:
Smalltalk allClasses select: [:each | each comment includesSubstring: 'xxxx' ]
External Package owners should also reintegrate too so these do not get lost when a new version of external packages get integrated. (for instance https://pharo.fogbugz.com/f/cases/12812 for Spec)
step by step it goes ...
Bye T.
Gesendet: Mittwoch, 05. Februar 2014 um 08:36 Uhr Von: Pharo4Stef <pharo4Stef@free.fr> An: "Pharo Development List" <pharo-dev@lists.pharo.org> Betreff: [Pharo-dev] comments :)
Thanks for all these comments!
On 05 Feb 2014, at 00:27, GitHub <noreply@github.com> wrote: 30742 12794 Class comments missing in UpdateStreamer package
https://pharo.fogbugz.com/f/cases/12794[https://pharo.fogbugz.com/f/cases/12794]
12802 Class comments missing for Kernel package
https://pharo.fogbugz.com/f/cases/12802[https://pharo.fogbugz.com/f/cases/12802]
12804 Class comment missing in AST packages
https://pharo.fogbugz.com/f/cases/12804[https://pharo.fogbugz.com/f/cases/12804]
12797 Class comments missing for tools package
https://pharo.fogbugz.com/f/cases/12797[https://pharo.fogbugz.com/f/cases/12797]
12796 Class comments missing for Traits package
https://pharo.fogbugz.com/f/cases/12796[https://pharo.fogbugz.com/f/cases/12796]
12798 Class comments missing in GroupManager package
https://pharo.fogbugz.com/f/cases/12798[https://pharo.fogbugz.com/f/cases/12798]
12806 Class comment missing in package FreeType + categorizing for
FreeTypeCacheTest
https://pharo.fogbugz.com/f/cases/12806[https://pharo.fogbugz.com/f/cases/12806]
12800 EyeContextInspector should be renamed to
EyeMethodContextInspector
https://pharo.fogbugz.com/f/cases/12800[https://pharo.fogbugz.com/f/cases/12800]
participants (5)
-
btc＠openinworld.com -
GitHub -
Nicolai Hess -
Pharo4Stef -
Torsten Bergmann