deprecating use traditional formatter
Hi In the new implementation of the code formattter I will remove useTraditionalPrecedence. This settings put additional parentheses around binary selector but I find it cumbersome While it may make sense for it turns foo ^ 1 + 2 * 3 into foo ^ (1 + 2) * 3 foo ^ 1 * 3 + 2 foo ^ (1 | 2) % 3 foo ^ 1 % 2 | 3 So let me know what you think but I will be hard to convince :) Stef
On 13 Nov 2019, at 09:04, ducasse <stepharo@netcourrier.com> wrote:
Hi
In the new implementation of the code formattter I will remove useTraditionalPrecedence. This settings put additional parentheses around binary selector but I find it cumbersome
While it may make sense for
it turns foo ^ 1 + 2 * 3
into
foo ^ (1 + 2) * 3
foo ^ 1 * 3 + 2
foo ^ (1 | 2) % 3
foo
^ 1 % 2 | 3
So let me know what you think but I will be hard to convince :)
I vote to remove it. The RB AST encodes parenthesis information, so that means that we can have a pretty printer keeping the parenthesis if they have been added by the original author. Adding new ones makes no sense to me. So I vote to remove. Marcus
I will do it :)
On 13 Nov 2019, at 10:05, Marcus Denker <marcus.denker@inria.fr> wrote:
On 13 Nov 2019, at 09:04, ducasse <stepharo@netcourrier.com> wrote:
Hi
In the new implementation of the code formattter I will remove useTraditionalPrecedence. This settings put additional parentheses around binary selector but I find it cumbersome
While it may make sense for
it turns foo ^ 1 + 2 * 3
into
foo ^ (1 + 2) * 3
foo ^ 1 * 3 + 2
foo ^ (1 | 2) % 3
foo
^ 1 % 2 | 3
So let me know what you think but I will be hard to convince :)
I vote to remove it.
The RB AST encodes parenthesis information, so that means that we can have a pretty printer keeping the parenthesis if they have been added by the original author.
Adding new ones makes no sense to me.
So I vote to remove.
Marcus
So I did it in https://github.com/Ducasse/enlumineur I will work on the removal of the previous formatter and the introduction of the new one. Stef
On 13 Nov 2019, at 10:06, ducasse <stepharo@netcourrier.com> wrote:
I will do it :)
On 13 Nov 2019, at 10:05, Marcus Denker <marcus.denker@inria.fr <mailto:marcus.denker@inria.fr>> wrote:
On 13 Nov 2019, at 09:04, ducasse <stepharo@netcourrier.com <mailto:stepharo@netcourrier.com>> wrote:
Hi
In the new implementation of the code formattter I will remove useTraditionalPrecedence. This settings put additional parentheses around binary selector but I find it cumbersome
While it may make sense for
it turns foo ^ 1 + 2 * 3
into
foo ^ (1 + 2) * 3
foo ^ 1 * 3 + 2
foo ^ (1 | 2) % 3
foo
^ 1 % 2 | 3
So let me know what you think but I will be hard to convince :)
I vote to remove it.
The RB AST encodes parenthesis information, so that means that we can have a pretty printer keeping the parenthesis if they have been added by the original author.
Adding new ones makes no sense to me.
So I vote to remove.
Marcus
participants (2)
-
ducasse -
Marcus Denker