Ohh ohhh, that was a bit too fast: I don't really see the point of PPElementParser? Why don't you just use aParser answer: anObject ? For the problems of your commit: - There is not a single test case. PetitParser had 99% test coverage before your commit. - All PPParser classes should have a class comment describing the class and its instance variables. - Please stick with the formatting conventions and don't leave commented code in the codebase. Cheers, Lukas On 13 August 2011 03:28, Damien Pollet <damien.pollet@gmail.com> wrote:
I've committed PPElementParser + a couple factory methods on PPPredicateObjectParser
On 12 August 2011 16:20, Damien Pollet <damien.pollet@gmail.com> wrote:
On 12 August 2011 07:21, Lukas Renggli <renggli@gmail.com> wrote:
Do you have a ready made-image somewhere? I don't understand it from reading your mail only.
Yup, get Pharo Coral from Jenkins: https://ci.lille.inria.fr/pharo/job/Pharo%20Coral/
-- Damien Pollet type less, do more [ | ] http://people.untyped.org/damien.pollet
-- Damien Pollet type less, do more [ | ] http://people.untyped.org/damien.pollet
-- Lukas Renggli www.lukas-renggli.ch