Begin forwarded message:
From: Joachim Geidel <joachim.geidel@onlinehome.de> Date: June 19, 2010 5:29:56 PM GMT+02:00 To: Stéphane Ducasse <stephane.ducasse@inria.fr> Subject: Re: Issue 2551 in pharo: Performance degradation of WeakRegistry in Pharo 1.1
Hello Stef,
I just saw that you have integrated Collections-ul.362 to fix the performance problem with WeakRegistry finalization.
For Squeak, I had also reported a deadlock (http://bugs.squeak.org/view.php?id=7546). In a discussion with Levente Uzonyi on the Squeak-dev list, we found that this was because WeakKeyDictionary executes the finalizers for gc'd elements in the scope of the protected block in WeakRegistry>>finalizeValues. As the WeakRegistry has no control over what the finalizers do, this is a potential source for deadlocks. This actually happens in JNIPort. The problem was introduced in Squeak 4.1.
Levente has fixed the problem in Collections-ul.365.mcz. He has not yet closed the Squeak issue 7546 yet; I have sent him a reminder. I think it would be better to integrate Collections-ul.365.mcz. Otherwise there will be deadlocks in Pharo too, at least with JNIPort. I can work around this, as JNIPort comes with its own subclass of WeakRegistry, but other users of WeakRegistry could run into the same problem. OTOH, I don't know what other changes have been introduced between Collections-ul.362 and Collections-ul.365, so there may be unwanted changes which are not good for Pharo.
Cheers, Joachim
------ Weitergeleitete Nachricht
Von: "pharo@googlecode.com" <pharo@googlecode.com> Antworten an: "codesite-noreply@google.com" <codesite-noreply@google.com> Datum: Sat, 19 Jun 2010 17:05:59 +0200 An: Joachim Geidel <joachim.geidel@bluecarat.de> Betreff: ***SPAM*** Re: Issue 2551 in pharo: Performance degradation of WeakRegistry in Pharo 1.1
Updates: Status: Fixed
Comment #6 on issue 2551 by stephane.ducasse: Performance degradation of WeakRegistry in Pharo 1.1 http://code.google.com/p/pharo/issues/detail?id=2551
(No comment was entered for this change.)
-- You received this message because you starred the issue. You may adjust your issue notification preferences at: https://code.google.com/hosting/settings
------ Ende der weitergeleiteten Nachricht