On 24 Aug 2015, at 14:55, Thierry Goubier <thierry.goubier@gmail.com> wrote:
2015-08-24 14:43 GMT+02:00 Sven Van Caekenberghe <sven@stfx.eu>: I have to concur, something very strange is wrong.
#50265
Load Zinc-Tests-SvenVanCaekenberghe.231 from http://mc.stfx.eu/ZincHTTPComponents
ZnEntityTests>>#testUnspecifiedEncoding should have today as latest version and it simply does not (the code is wrong too), I can't imagine how that is possible.
And this is with loading code ... seems quite dangerous.
Ok. Copying in a filetree repo Zinc-Tests-SvenVanCaekenberghe.231 nets me this code
testing testUnspecifiedEncoding | json bytes entity | json := '{"text":"Der Weg zur Hölle ist mit guten Vorsätzen gepflastert."}'. entity := ZnEntity with: json type: ZnMimeType applicationJson setCharSetUTF8. bytes := entity asByteArray. ZnDefaultCharacterEncoder value: ZnUTF8Encoder new during: [ entity := ZnEntity readFrom: bytes readStream usingType: ZnMimeType applicationJson andLength: nil. self assert: entity contents equals: json. entity := ZnEntity with: json type: ZnMimeType applicationJson. self assert: entity encoder equals: ZnUTF8Encoder new ]
and that timestamp: "testUnspecifiedEncoding" : "SvenVanCaekenberghe 8/24/2015 14:30",
Yes, that is the correct code with a version dated today.
But, yes, loading in the image nets me an older version: 5/4/2014, is that what you have?
The version dated 5/14/2014 is a wrong one. The version dated 5/2/2015 would be good too. Thanks for having a look, Thierry. It is a good thing if at least file tree does it correctly.
Looks like the MC side is correct (i.e. there is a correct MCMethodDefinition in the system). Has something changed related to code or methods comparisons recently?
Thierry
On 24 Aug 2015, at 13:30, Thierry Goubier <thierry.goubier@gmail.com> wrote:
2015-08-24 13:25 GMT+02:00 Thierry Goubier <thierry.goubier@gmail.com>: I'm trying on 50264, and, yes, there is something strange:
Monticello diff only picks up two of the changes, instead of three.
Ok, by reformatting, ended up with exactly the same code for one of them :(
Saved in the package cache and I have everything saved.
Some suspicious/wrong data in your image?
Thierry
Thierry
2015-08-24 12:05 GMT+02:00 Marcus Denker <marcus.denker@inria.fr>: Hi,
I have a *very* strange bug.
I am trying to add change these three methods in class âTemporaryVariableâ: (I copy the new version):
ensureProperties method saveTemp: self. ^ Properties at: self ifAbsentPut: WeakKeyDictionary new
removePropertiesIfEmpty ^ Properties at: self ifPresent: [ :dict | dict ifEmpty: [ method removeSavedTemp: self. Properties removeKey: self ] ]
hash
^ (name hash bitXor: method hash) bitXor: (startpc ifNil: 0)
Now when I save the MC package, these changes are *not* saved, even though when I diff against the repository of Pharo5, they are shown as different.
The only special things I did is to move TemporaryVariable to a new tag some updates ago. And I had extension methods in *slot where the same thing happened, but that was fixed by putting them into *Slot.
This looks like some wired RPackage problem. But the RPackage seems to correctly know TemporaryVariable and these three selectors as local from the package Slot.
I really have no idea what the problem could be.
Marcus