Re: [Pharo-project] OB contextual menu item 'method containing' broken: is it useful?

July 10, 2010


      If i remember correctly this is fixed and the bug is closed already a
while ago. Or is this something new?

Lukas

On Saturday, July 10, 2010, Mariano Martinez Peck <marianopeck@gmail.com> wrote:
...
Hi Simon. Can you open a bug ticket please?
Lukas, it seems very easy to fix. If you want you can commit this change:
OBSelectorNode >> methods
Â Â Â  methods ifNil:
Â Â Â  Â Â Â  Â Â Â  [methods := SystemNavigation default allMethodsSelect:
Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  [:m |
Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  m hasLiteralSuchThat:
Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  [:lit |
Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  lit isString and:
Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  [lit isSymbol not
Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  Â Â Â  and: [lit includesSubstring: selector string caseSensitive: false]]]]].
Â Â Â  ^ methods collect: [:m | OBMethodNode on: m]
I only changed allMethodsNoDoitsSelect:Â  byÂ  allMethodsSelect:
Cheers
mariano
On Tue, Jul 6, 2010 at 11:50 AM, Simon Denier <Simon.Denier@inria.fr> wrote:
In 1.1 RC4 (and before), when opening the contextual menu in the source pane, there is an option for 'method containing' among the search actions.
It's not clear what is is supposed to do. Is it the OB implementation of the 'method strings with it' action, which is also available?
Anyway, it is broken as it raises a DNU #allMethodsNoDoitsSelect:
--
Â Simon
_______________________________________________
Pharo-project mailing list
Pharo-project@lists.gforge.inria.fr
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- 
Lukas Renggli
www.lukas-renggli.ch