Hi nicolai could you publish your code somewhere? Le 20/12/14 01:32, Nicolai Hess a écrit :
Stef refactored all dockingbar related things out of MenuMorph into DockingBarMenuMorph, the problem is, spec does not distinguish between - create a popup menu from a spec - create a dockbar menu from a spec
I do not remember the use of DockingBarMenuMorph (sigh... doing too mnay things). But is it needed?
I tried to implement this by providing a new buildWithSpecAsMenu and changed the MorphicMenuAdapter to create a MenuMorph (for popup menus) and DockingBarMenuMorph (for the other one).
But it turns out I had to duplicate all the xPopup methods: buildWidgetPopup - buildWidgetMenu adaptAsPopup - adaptAsMenu buildWithSpecAsPopup - buildWithSpecAsMenu
May be we should push your change.
and this doesn't look right to me. As MorphicMenuAdapter is the only MorphicAdapter that implements special adaptAsX method, all this (popup-)menu related build/adapt methods looks like a hack. But I am not sure.
It is certainly a hack. Menu were not really thought.
Maybe someone with more knowledge about spec internals can take a look on this issue.
nicolai
2014-12-14 21:15 GMT+01:00 stepharo <stepharo@free.fr <mailto:stepharo@free.fr>>:
So then this is probably my mistake. Now I will not have the time to work on it before at least a week. Too many other things to do that are not Pharo related.
Stef
Le 14/12/14 17:24, Peter Uhnák a écrit :
in which version of Pharo are you? I cleaned a lot menu in 40 so this is probably related. Do you have an example I could execute?
Yes this happens on Pharo 4.
Yes, Pharo 4
ApplicationWithToolbar new openWithSpec then, open the "File"-menu -> MenuMorph(Object)>>doesNotUnderstand: #activatedFromDockingBar: