2010/6/11 Fernando olivero <oliverof@lu.unisi.ch>
Hi Laurent, great work! We need more documentation!
Laurent -> Hilaire :)
Just a little coding style i would like to point out.
I see you are using lazy initialization, but in this case i believe its a miss-use of the pattern. Because you always will have a toolbar and a menu bar, since the creation you are sure you need them, why not go and just initialize them before installing.
Let me know what you think.
So i propose changing the implementation to :
initialize super initialize. self initializeMenuBar. self initializeToolbar. ....
and
initializeMenuBar | menu | menu := self window newMenu. menu addToggle: 'Load' target: self selector: #load. menu addToggle: 'Save' target: self selector: #save. menubar := self window newToolDockingBar. menubar add: 'File' font: self window theme menuBarFont icon: nil help: 'File operations' subMenu: menu.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project