Name: Refactoring-Core-lr.149 Author: lr Time: 15 August 2010, 5:18:09 pm UUID: 27652b7f-9069-49e2-ad79-b6c3ecb077d9 Ancestors: Refactoring-Core-lr.148 - removed all references to Preferences Name: ShoutWorkspace-lr.7 Author: lr Time: 15 August 2010, 5:20:07 pm UUID: 851aa393-9367-4731-b695-1bcec55add0c Ancestors: ShoutWorkspace-lr.6 - removed all references to Preferences Name: Shout-lr.86 Author: lr Time: 15 August 2010, 5:20:53 pm UUID: 07aa43a8-8669-4cc8-b5a7-e8c8f002adfd Ancestors: Shout-lr.85 - removed all references to Preferences (next is to add settings for the format, but that requires quite some heavy changes) Name: OmniBrowser-lr.487 Author: lr Time: 15 August 2010, 5:25:43 pm UUID: fc4947b3-c23c-4cbb-a7af-7876306dc8de Ancestors: OmniBrowser-lr.486 - removed all references to Preferences Name: OB-Standard-lr.488 Author: lr Time: 15 August 2010, 5:26:21 pm UUID: 8a31228c-89e8-4450-8408-9d47576d9db5 Ancestors: OB-Standard-lr.487 - removed all references to Preferences Name: OB-Tests-Core-lr.83 Author: lr Time: 15 August 2010, 5:26:43 pm UUID: 8ebb0466-c329-4eaa-a5a9-9e1114cf5da2 Ancestors: OB-Tests-Core-lr.82 - removed all references to Preferences Name: OB-Tests-Morphic-lr.28 Author: lr Time: 15 August 2010, 5:27:19 pm UUID: 043cf6f5-a9dd-4c9e-8846-fe43a280de07 Ancestors: OB-Tests-Morphic-lr.27 - removed all references to Preferences Name: OB-Tests-Standard-lr.115 Author: lr Time: 15 August 2010, 5:27:39 pm UUID: 3459c99b-df43-4ad9-b277-e579ff5a9bff Ancestors: OB-Tests-Standard-lr.114 - removed all references to Preferences 2010/8/15 Mariano Martinez Peck <marianopeck@gmail.com>:
On Sun, Aug 15, 2010 at 2:58 PM, Lukas Renggli <renggli@gmail.com> wrote:
On Sunday, August 15, 2010, Marcus Denker <marcus.denker@inria.fr> wrote:
On Aug 15, 2010, at 1:56 PM, Mariano Martinez Peck wrote:
But I think we should add back a Preferences class for allowing to load old code. (it's referenced in the class side initialize in old code often...)
Please don't add such a fake classes, it just makes everything more difficult and less functional. People should not use outdated code, and if they do they should be able to fix it themselves.
I am fixing right now the remaining references in OB and Shout (RB and eCompletion are already fixed).
Lukas, Shout won't load in Pharo 1.2 because of issue
http://code.google.com/p/pharo/issues/detail?id=2734
:(
Lukas
The problem are the external pacakges. I have 100 references to Preferences in Pharo dev....almost EVERY external package uses Preferences. So....we really need help of the external package maintainers to update them. And I am not sure how easy is that. What should be easy is to have a Preferences class that supports the simple API that everyone was using: add a preference. And make Preferenceclass return true or false for that preference. That should be 90% of all usages, I guess.. We can do that by just having a dictionary and overriding doesNotUnderstand:. We should not provide all this magic that used to be there, e.g.compiling on the fly methods for accessed perferences (which funnily had an empty source pointer...). I mean...is there a mapping between each previous preference a the new ones?
In 1.1, Preferences are returning the values from the Settings framework for backward compatibillity. But I don't think that Preferences added are shown in the Settings? This would require Settings to be generated, which is possible but I thinknot really what we want. One could of course build this specification for the Preferences... and maybe there was even code there for that ;-) I started the cleanup bu removingunsent messages... but after a while that got really boring. And Preferences was a  near 2000 LOC abdomination of a class. I checked in 1.1Dev, and most of the references are from the Core, which we removed in 1.2...    Marcus
--Marcus Denker  -- http://www.marcusdenker.de <http://www.marcusdenker.de/> INRIA Lille -- Nord Europe. Team RMoD.
-- Lukas Renggli www.lukas-renggli.ch
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Lukas Renggli www.lukas-renggli.ch