On Fri, May 14, 2010 at 12:15 AM, Stéphane Ducasse < stephane.ducasse@inria.fr> wrote:
On May 13, 2010, at 11:33 PM, Mariano Martinez Peck wrote:
Ok...now it seems to be working again. However, It takes MUCH more time than in Pharo 1.0.
can you be more precise?
Yes, I can: "In PharoCore 10517" MessageTally time: [Smalltalk condenseChanges]. -> 8127 "In PharoCore 11357" MessageTally time: [Smalltalk condenseChanges]. 490523
Apparently they are a lot of methods hanging around and they should be cleaned. Now we do not care that condense Changes is fast or not. It works so perfect.
Yes. But I am intrigued why.
I really don't care too much, I just want to know if this is expected or not.
Cheers
Mariano
On Tue, May 11, 2010 at 8:41 PM, Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com> wrote: 2010/5/10 Stéphane Ducasse <stephane.ducasse@inria.fr>:
nicolas
do you have an idea where we can look?
Stef
Sorry, I don't have time to dig into it... But I think invent is a more appropriate verb than look in this case. The ideas of Igor sound good to me, delegate some to CompiledMethods and maybe use a mass becomeForward
Nicolas
On May 10, 2010, at 6:26 PM, Nicolas Cellier wrote:
Sorry for the infinite loop, it was my fault. I thought it had been detected and solved already (in squeak ?).
Destroying source pointer of un-installed methods was just a workaround to be used in case of already broken sources. There is another strategy : detect the source pointer of un-installed methods and store them in the new change log. This has to be done before logging source code of installed methods.
Nicolas
2010/5/9 Igor Stasenko <siguctua@gmail.com>:
On 9 May 2010 23:17, Alain Plantec <alain.plantec@free.fr> wrote:
Ok, i took the 11343 - fixed the #condenseChanges - ran Smalltalk condenseChanges - changed the single method - saved image - ran Smalltalk condenseChanges again
no crash reported.
Indeed, with 11343 it seems ok. With 11326 (updated -> 11346), crash during the second
condenseChanges :(
Alain, could you please send me an image +.changes saved just before running a second condenseChanges? I'll try to find the cause of it.
Alain
Alain
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
-- Best regards, Igor Stasenko AKA sig.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project