I agree with adrian. I would like to use the stream as a test for Call For Improvement Process. So could you come up with a kind of template Summary: Key points: Some tests to illustrate Actions/Process Stef On May 30, 2008, at 6:17 PM, Adrian Lienhard wrote:
On May 30, 2008, at 15:37 , Damien Cassou wrote:
On Fri, May 30, 2008 at 2:18 PM, Adrian Lienhard <adi@netstyle.ch> wrote:
Have you verified that your change does not inadvertently modify any behavior? Its not likely, but changes like this can introduce subtle bugs. For instance, Matrix overrides readStream. So if there exists any use of "ReadStream on: aMatrix" that is there to bypass the overridden behavior, the code will break.
It should not break anything (if it does, the test will fail and I will fix things :-)). In fact, ReadStream only deals with SequenceableStreams so it should be ok. Do you agree?
No I don't agree. Because it is not likely that there is a test for Matrix that will show a potential bug. I just wanted to point out that it is important to precisely look at the effect of such "global" transformations. (E.g. like Edgar tried to replace all #== with #= IIRC ;)
With your proposed change, I think it is unlikely you will break anything, but you cannot say for sure without detailled *manual* checking. The difficulty is that you theoretically needed to verify that there is never passed a Matrix instance to "ReadStream on:".
Also to consider with such changes is that you may break external code that you don't know of. To sum up, I'm not against such improvements at all, but they have to be done carefully, i.e., the argument that tests will show any problem does not hold.
Cheers, Adrian
-- Damien Cassou Peter von der Ahé: «I'm beginning to see why Gilad wished us good luck». (http://blogs.sun.com/ahe/entry/override_snafu)
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project