On Tue, Nov 24, 2015 at 9:07 AM, Nicolai Hess <nicolaihess@gmail.com> wrote:
2015-11-24 13:01 GMT+01:00 Marcus Denker <marcus.denker@inria.fr>:
I will put it on the TODOâ¦. sadly I am a bit busy and canât postpone the other things now to work on this.
No problem. An idea how this should be solved.
I think that SyntaxErrorDebugger should not care about the category. It's a very exceptional case and recatogorizing a method in that case is not too much to ask. The self flag: #hack. "Should use the new OPalWarnings directly instead of recreating a SyntaxErrorNotification" is not really good because OC falls back on calling #notify:at:... on the requestor in non-interactive mode. The whole error handling needs to be improved, but we can only do that *after* we remove the old Compiler. This is why I did not invest yet into cleaning and simplification... it is impossible if we have to stay compatible.
On 20 Nov 2015, at 18:19, Nicolai Hess <nicolaihess@gmail.com> wrote:
Any idea how to solve this:
16961 <https://pharo.fogbugz.com/f/cases/16961/Unable-to-accept-changes-in-SyntaxEr...> Unable to accept changes in SyntaxErrorDebugger -> DNU: receiver of asSymbol is nil and 16723 <https://pharo.fogbugz.com/f/cases/16723/File-in-a-file-with-an-error-does-no...> File in a file with an error does not set the doitFlag well
If you file in some code that with syntactic errors, you can not fix the code from within SyntaxErrorDebugger because 1. the doitflag is nil, and If we would change this, init it with true... 2. ... the category is nil
From where it is used and comments like:
notify: message at: location in: code self flag: #hack. "Should use the new OPalWarnings directly instead of recreating a SyntaxErrorNotification" SyntaxErrorNotification inClass: STCommandLineHandler category: nil withCode: code doitFlag: nil errorMessage: message location: location.
it looks like the usage for SyntaxErrorNotification should be cleaned reworked, any ideas what to do? I can not find a Opal OCSytaxEror or something like this. And I don't understand the workflow of raising and catching and reraising SyntaxErrorNotifications.
-- -- Marcus Denker -- denker@acm.org http://www.marcusdenker.de