On Mon, Dec 28, 2009 at 6:42 PM, Adrian Kuhn <akuhn@iam.unibe.ch> wrote:
Mariano Martinez Peck <marianopeck@...> writes:
Hi Adrian! Thanks for trying to fix this. However, I can still reproduce the problem. I put a halt in my expectedFailures method and it is being called [..] The iteration throught the do: seems to be ok, but I don't know why, the tests are still considered as error (red) instead of expectedFailures in green. Is correct to put "outcome: TestFinished failures;" ??? I guess it would be something like "outcome: TestFinished expectedFailures" but I look in the class side methods of TestFinished and I only see passed, failure and error. Let me know if I can test something more.
I see, you got the same case as Alex.
You declared an expected *error* in #expectedFailures. That used to work with the old SUnit but the new SUnit takes you literally and expects it to be a failure and a failure only. I will work on a solution for that.
Ahhh yes, sorry. I just discovered that. Wait...I will suggest this: It is true what you said about expectedFailure is expected failure and not expected error. I just did it like that because I thought it was like that. But now that I see it, that is probably wrong. So, what I would do is to "fix" it but (I don't know) put is as deprecated so that all the tests of the people are still green and give them time to change it to expectedErrors or similar. After a second release you can remove this fix :) What do you think ? Cheers Mariano
--AA
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project