On 03 Oct 2015, at 10:13, Esteban Lorenzano <estebanlm@gmail.com> wrote:
Hi,
this is an ongoing change. I still need to push two slices :) Final change will be backward compatible.
What we are doing is eliminating the multiple icon sets from the image⦠we will have just one, and people will be able to load others if desired, but they *will not* live inside the image (I would like to make the same for themes, but thatâs a lot more complicated). The idea is that people can contribute icons / iconpacks same way linux distros work (ok, we are not as big, but you get the idea).
On 02 Oct 2015, at 19:40, Torsten Bergmann <astares@gmx.de> wrote:
The latest changes on ThemeIcons completely broke functionality and icons of external and included packages.
1. Intelli J Icons are now used as default, but most icons of external packages (Pomodoro, MongoTools, EventRecorder, ScriptManager, ....) align with the eclipse icon set. Can we please stay with Eclipse as default so that we do not have to introduce intelliJ icons on each external project as well?
not really. we decided the change because eclipse icons do not work at all with dark-theme (and there is no easy way to adopt the svg eclipse icons) So after trying a couple of things, we decided that this iconset works fine in all themes (eclipse maybe do not break existing tools, but you cannot use eclipse with dark theme so many people are outside). You will still be able to change to eclipse pack if desired.
2. The mechanisms of ThemeIcons class do not work anymore. The icons in Versionner are lost. Also other external package who extended ThemeIcons (like DesktopManager) are now broken. Just try to load it into a Pharo5.0 Latest update: #50359 now.
As I say, extension to theme icons will be compatible, just let me finish :) now⦠all subclasses will go away so projects will need to adapt (they will need to extend ThemeIcons instead his children).
3. Some of the icons are removed - for instance in catalog and moved to be retrieved from Github. But we wanted to componentize the image into configs. So the icons of catalog should belong to this project. Right?
more or less⦠we do not have still a good way to do that. so, we are adopting something like a âlinux desktopâ style: we allow icon packs to include icons specific to tools.
for example, nothing is agains having
idea11/eclipse/other icons overlays versionner catalog etc.
is not perfect, but since is how linux distros work, I think finding a good solution is not so easy (Iâm playing with some pragma-based ideas but not sure how to implement them yetâ¦)
4. I can not open the settings in the latest image anymore because the icons are tried to retrieve from Github using a HTTPS connection. Doesnt work either because I'm on Windows, because of HTTPs, because ZnClient does not deal with a firewall correctly. It is not good to rely on additional external downloads directly.
not that I did not think about :)
ouch⦠I meant: ânow, that I did not think about :)" which is exactly the contrary of what it looks with the typo :)
in fact you do not need to go out, is just the way I implemented it in settings. If you have icons package in ./icon-packs, they will be load from there, I will change some stuff then:
- I will not auto-fetch available packs. Instead, I will add a âfetchâ button in settings. - I will make possible to specify urls/directories to fetch. - I will add a way to do something like that:
ThemeIcons new loadFromArchive: aReference; beCurrent.
so anyone can have the iconset they want in their machine and load in startup without going through internet.
I know we want to make progress ... but were such changes discussed on the list before?
I think we discussed it but like one-two years ago⦠just now I got burned by spur and I did this âto relax a bit" :)
Iâm sorry if we failed again with communication, sometimes we do not do the movements in right order :( I will try to enhance that.
Esteban
Thx T.