Sorry I meant compareToCurrentVersion... Regards, Gary ----- Original Message ----- From: Mariano Martinez Peck To: Pharo-project@lists.gforge.inria.fr Sent: Wednesday, January 20, 2010 9:04 AM Subject: Re: [Pharo-project] After OB,compare to current version uses old diff I created the issue http://code.google.com/p/pharo/issues/detail?id=1855 On Tue, Jan 19, 2010 at 8:38 PM, Mariano Martinez Peck <marianopeck@gmail.com> wrote: Gary: I compared that method before and after loading OB and it is the same. The method is from gvc 2/9/2009 12:45 like this: compareToOtherVersion "Prompt the user for a reference version, then spawn a window showing the diffs between the older and the newer of the current version and the reference version as text." | change1 change2 s1 s2 | change1 := changeList at: listIndex ifAbsent: [^self]. change2 := UIManager default chooseFrom: (list copyWithoutIndex: listIndex) values: (changeList copyWithoutIndex: listIndex). change2 ifNil: [^self]. s1 := change1 string. s2 := change2 string. s1 = s2 ifTrue: [^self inform: 'Exact Match' translated]. (DiffMorph from: s1 to: s2 contextClass: change1 methodClass) openInWindowLabeled: (('Comparison from {1} to {2}' translated) format: {change1 stamp. change2 stamp}) On Tue, Jan 19, 2010 at 8:29 PM, Stéphane Ducasse <stephane.ducasse@inria.fr> wrote: do you have the correct version? The problem is certainly link with override and moving package around (this is bogus with MC). Stef On Jan 19, 2010, at 7:00 PM, Gary Chambers wrote: > Clearly the cruicial method is overwritten... VersionsBrowser>>compareToOtherVersion. > > Regards, Gary > ----- Original Message ----- > From: Mariano Martinez Peck > To: Pharo-project@lists.gforge.inria.fr > Sent: Tuesday, January 19, 2010 5:57 PM > Subject: Re: [Pharo-project] After OB,compare to current version uses old diff > > > > 2010/1/19 Gary Chambers <gazzaguru2@btinternet.com> > Unless code has changed then the setting for "Use Polymorph difference tools" should do. > I expect some code regression may have happened though. > > Thanks Gary. The preference is the one Henrik said, useNewDiffToolsForMC, but it is not working for me. You can try it like this: take the latest PharoCore 1.0 image, (10506). You will notice that it is working with the new diff. Then, evaluate: > > Gofer new > squeaksource: 'MetacelloRepository'; > package: 'ConfigurationOfOmniBrowser'; > load. > > > ((Smalltalk at: #ConfigurationOfOmniBrowser) project version: '1.0') load. > > Or download OB by hand from Lukas repo. > > After this, you will notice it uses the old diff even if the preference is enable and even disabling it and enabling again. > > Cheers > > Mariano > > > Regards, Gary > ----- Original Message ----- > From: Mariano Martinez Peck > To: Pharo-project@lists.gforge.inria.fr > Sent: Tuesday, January 19, 2010 4:35 PM > Subject: Re: [Pharo-project] After OB,compare to current version uses old diff > > > > On Tue, Jan 19, 2010 at 5:22 PM, Henrik Johansen <henrik.s.johansen@veloxit.no> wrote: > Preferences >> useNewDiffToolsForMC? > > I tried this before sending the email, but not. I didn't work :( > > > There was some discussion some time back, I believe Lukas stated he liked the old tools better. > > Ok..didn't know. > > Can't say I blame him, I'm never quite sure if I'm installing new one or keeping old when merging from MC until after the fact when I use the Polymorph tools ... > > > I can blame him at all. He is helping us a lot maintaining OB a lot. If we use his OB repository, then we should adapt to him. I don't pretend he change his default values or preferences. I just want to know how to set up again the new diff :) > > Cheers > > Mariano > > Cheers, > Henry > > On Jan 19, 2010, at 5:05 26PM, Mariano Martinez Peck wrote: > > > Hi: If you take a PharoCore image, and browse the editions of a class, then select an older one, and then select "compare to current", you see the differences using the "new" diff, the same that we use in MC. > > > > However, after installing OB in a core image, it uses the "old" version. I am not sure that change is due to OB, but at least it seems. I checked in Preferences but I didn't find anything. > > > > Any hint how to put new diff again after installing OB ? > > > > Thanks! > > > > Mariano > > _______________________________________________ > > Pharo-project mailing list > > Pharo-project@lists.gforge.inria.fr > > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > _______________________________________________ > Pharo-project mailing list > Pharo-project@lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project@lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > _______________________________________________ > Pharo-project mailing list > Pharo-project@lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > > > > _______________________________________________ > Pharo-project mailing list > Pharo-project@lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project > _______________________________________________ > Pharo-project mailing list > Pharo-project@lists.gforge.inria.fr > http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project ------------------------------------------------------------------------------ _______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project