Thanks alex. More context is important :) Thanks for the slice. Stef
Pharo image: Pharo-core Pharo core version: 11110 Virtual machine used: Squeak 4.2.1beta1U
This email takes the fixes sent in the email having the subjet: - [squeak-dev] The Trunk: KernelTests-bs.121.mcz - [squeak-dev] The Trunk: Kernel-bs.330.mcz
Alex what was the fix for?
"The Trunk: Kernel-bs.330.mcz" fixes a bug in AdditionalMethodState>>at:put: "The Thunk: KernelTests-bs.121.mcz" defines a small test method that is green only with the bug in at:put: fixed
The bug that has been identified by Andreas is that when you add twice the same binding, then you have an infinite loop at the second addition.
After loading the .cs, we have for MethodPropertiesTest: 11 run, 5 passes, 5 expected failures, 0 failures, 1 errors, 0 unexpected passes
and before?
Before the fix: 10 run, 4 passes, 5 expected failures, 0 failures, 1 errors, 0 unexpected passes
After loading the .cs file: 11 run, 5 passes, 5 expected failures, 0 failures, 1 errors, 0 unexpected passes
(I use a 11110 core for this)
The error left is for testAnalogousCode, not related to this fix.
Thanks to Andreas Raab for the fix.
Note to the reviewer: I put a .cs file on google code. Is that okay with you? Or do you prefer a SLICE in the Inbox?
What is nice with slice I that we can merge easily and see them in the inbox.
Ok, it is now as a slice. SLICE-FixAndTesstForAdditionalMethodStateAtPut-Alexandre_Bergel.1
Alexandre -- _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;: Alexandre Bergel http://www.bergel.eu ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project