Dale Henrichs-3 wrote
Guillermo,
Apparently you don't like the github browser-based code review tool?
What are your objections?
Do you know of a better tool that is out in the wild or do you just have visions that code review could be better?
Let me add some thoughts on review tools, not as an argument against anything in this thread, but more like nostalgia for what I have used in the past and would like to see again. What I describe was specifically oriented toward 1:1 peer reviews and self reviews. VA Smalltalk has a difference browser which has the usual browser top panes (in the case of VA, showing Application, Class, and Method lists) and side-by-side bottom panes showing the two versions of the code for the selection in the top panes. It also has a button that allows you to step through the changes, highlighting each successive difference. (It also has substantial room for improvements!) The things I like about it are: - it's live in my image, so all the usual things one can do with Smalltalk are possible - I can easily review other versions of the artefacts - I can jump around to follow related artefacts (e.g., look at a changed method called from the current one or vice versa) - I can *remove artefacts from the lists* as I finish with them so that my browser works as a structured check list and as I eliminate things I can can see what remains and eventually empty the lists, signifying completion - I can modify the changes to correct problems with them and then publish an updated change (or in Git terms a new commit) So, these are some of the characteristics I would like to find in a review tool.
Better tools are always possible, but it is sometimes nice to use a tool that you didn't have to build from scratch while creating the better tool:)
Dale
On 10/27/2016 05:06 AM, Guillermo Polito wrote:
I would like to have a good code review tool, before having to do one ad-hoc...
On Thu, Oct 27, 2016 at 1:50 PM, Denis Kudriashov <
dionisiydk@
<mailto:
dionisiydk@
>> wrote:
Hi.
With future transition to github I ask myself what tools we will have out of the box. I google a bit and found these nice service http://ghv.artzub.com. Try to search guillep and then pharo-core. It looks really nice.
What other online services you know to analyse github projects?
-- View this message in context: http://forum.world.st/GitHub-code-analytics-tools-tp4920385p4920581.html Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.