Mariano Martinez Peck wrote:
On Fri, Jun 11, 2010 at 7:25 PM, Yanni Chiu wrote:
The other Glorp patch is the Scanner change for '_' (in method names).
Ok, but this is working ok in Pharo 1.1. Isn't it ?
The patch works, and is still needed for Pharo 1.1 - I can check further, if you think it is no longer needed. I compared the code and it has a minor change from what's in Pharo 1.1. (I had to reformat both versions, before doing the diff). There was a discussion on allowing '_' in method names in the Squeak list a few months ago. I'm not sure what the Pharo stance is. I thought this patch was the cure for problems loading Glorp test code (which have '_' in the method names), but like I said, if Pharo 1.1 is already supposed to accept '_' in method names, I can investigate the patch further.
In PharoCore-1.1, two more tests fail:
GlorpTest.GlorpManyToManyDBTest.testReadNodeAndDeleteChildWithSaveAndContinue GlorpTest.GlorpUnitOfWorkTest.testRollbackOneToManyAfterAdd
Why you put the namespaces? you confuse me with VW ;)
The results are from a copy&paste from a Hudson build test report. The latest Hudson build code adds the psuedo-package names.
In PharoCore-1.0, only these three tests were failing: GlorpTest.Extras.GlorpMainBackendTest.testSetToBaseTestAFacility
forget this one. My problem. I need to fix it.
GlorpTest.GlorpRowMapForMementosCollectionTest.testRBSmallDictionary
IIRC, this test seemed to make overly specific assumptions about the Dictionary implementation.
GlorpTest.GlorpSelectCommandTest.testExecute
Can't remember anything about this one.