I just checked the 3.10 image. There is no IntegerTest>>testHex, but there is an Integer>>hex which behaves differently from what you specified. I really don't understand what this is all about. I suggest to drop IntegerTest>>testHex for now. - on On Jun 10, 2008, at 9:03 PM, Oscar Nierstrasz wrote:
Hi Stef,
I loaded a fresh pharo-dev image and updated everything. Then the testHex tests failed, so I fixed them.
Can you please tell me which implementors of hex you find in your image?
I only find Character>>hex and Float>>hex. I had to implement Integer>>hex myself.
- on
On Jun 10, 2008, at 6:38 PM, Stéphane Ducasse wrote:
testHex self assert: $a hex '61' = '61'. self assert: Character space hex = '20'
is green on my image
as well as this one
testHex self assert: 0 hex = '0'. self assert: 12 hex = 'C'. self assert: 1234 hex = '4D2'.
They are red in yours?
Stef
On Jun 10, 2008, at 4:00 PM, Oscar Nierstrasz wrote:
Well, I thought we would start to fix the existing broken tests before adding new broken tests.
I would also be very happy to see some comments when someone adds a new broken test, so I know what the plan is.
Now I added an implementation of Integer>>hex, for example, but I am not so sure why we need this. Ain't too many senders. An easier fix would have been to remove the broken test.
Cheers, - on
On Jun 10, 2008, at 15:53, Bill Schwab wrote:
Is your concern that the new tests are broken (which seems normal to me that they would start out that way), or are you objecting to their being included in the image?
I can see arguments either way on the latter. If code in the image is wrong and a clearly correct but currently failing test highlights it, I'd rather be alerted to it. You are also correct that having them included draws attention that could easily encourage duplication of effort.
Comments?
Bill
Wilhelm K. Schwab, Ph.D. University of Florida Department of Anesthesiology PO Box 100254 Gainesville, FL 32610-0254
Email: bschwab@anest.ufl.edu Tel: (352) 846-1285 FAX: (352) 392-7029
oscar@iam.unibe.ch 06/10/08 8:31 AM >>>
I looked at the wiki page http://code.google.com/p/pharo/wiki/CurrentlyWorkingOn but it does not say much.
I would like to work through some tests, but I cannot find an overview.
The tests CharacterTest>>testHex and IntegerTest>>testHex are broken but seem to be very new. Stef, are you working on these? You seem to have written the tests ...
- on
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project