Nov. 20, 2015
4:06 p.m.
Hi, The class SystemAnnouncer has #restoreAllNotifications method that is called only by RPackageRenameTest>>setUp. This is pretty strange. I have an impression that tests should not affect global information (singleton). And there are some objects that depends on calling #restoreAllNotifications. I guess that all this staff works thanks to this particular test case. I think this is a bug and correct solution should be: -=-=-=- uniqueInstance "Answer a system annoncer." ^ announcer ifNil: [ announcer := self new. self restoreAllNotifications. announcer ]. -=-=-=- And it should be removed from RPackageRenameTest>>setUp. What do you think? Should I open an issue? Cheers, Juraj