Hi Sven, Thanks for your feedback. On Mon, Jul 11, 2016 at 08:33:56AM +0200, Sven Van Caekenberghe wrote:
Hi,
Regarding the DateAndTime change.
On 11 Jul 2016, at 07:52, Alistair Grant <akgrant0710@gmail.com> wrote:
I've finally got this to the point where I think it can be submitted.
The previous version missed a case (sql between). To keep backward compatibility with earlier versions of UDBC SQLite3 I've sacrificed a bit of conformaty and made the representation:
YYYY-MM-DD HH:MM:SS.ssssss
(the difference being microseconds instead of millseconds). My limited interoperability testing (Python / Django) suggests this shouldn't be a problem.
The tricky bit is that it affects four different packages:
1. UDBC-SQLite-Base (UDBCSQLite3Statement, PierceNg.49) 2. Glorp (UDBCSQLite3Platform, AlistairGrant.129) 3. Kernel (DateAndTime, TheIntegrator.2293) 4. Kernel-Tests (DateAndTimeTest, TheIntegrator.65)
I assume that I can create a fogbugz issue and submit a single slice that will contain the changes to DateAndTime and DateAndTimeTest for Pharo 6.
Yes, please create a slice. But first for Pharo 6, then back port to 5.
Shall do.
I assume that your change is adding the default timezone parameter ?
Yep, so that applications can have a default timezone (offset) of UTC.
A small remark: in your unit tests, don't compare string output, but objects. In the 1st test, compare to Duration zero, in the second to 2 hours.
Done.
Sven
What's the best way to submit this for Pharo 5?
The Glorp changes are dependent on the Kernel changes, and the UDBC-SQLite-Base changes are dependent on the Glorp changes.
I guess that for Glorp, the best way is to include the Kernel changes as an extension for Pharo 5.
How is a dependency such as that between UDBC-SQLite-Base and Glorp normally handled?
I've finally realised the obvious, that making UDBC-SQLite-Base dependent on Glorp, is a bad idea since not everyone using UDBC will have Glorp, so I'll reverse the dependency, since the UDBC driver has to be present for Glorp to use it :-). Thanks again, Alistair