Le 27/02/2015 10:26, Marcus Denker a écrit :
Hi,
#517 contains the cleanup by Pablo Herrero related to the AST. It used to be that some AST nodes did hold on to Scanner tokens. This is nota good idea as the existence of a scanner is an implementation choice: modern parsers are scanners-less, for example.
I'm under the feeling that often, scanner-less parsers hides a lexer behind syntax tricks for efficiency reasons ;) In that change, you trade tokens against a few additional instance variables here and there in the AST where it used to be taken care by the token.
-> We need to carefully test -> the API changed for those cases where it wanted tokens to be passed -> the RBMessageNode now holds on to the selector + #selectorParts is created, while is used to be that selectorParts was the main thing and selector calculated from that.
I agree. Thierry