Hi Stef, I harvested most of the remaining changes in the inbox, including Norberts fix (see other mail in this thread). - changed WeakRegistry to use WeakIdentityKeyDictionary (http://bugs.squeak.org/view.php?id=6347 ) - FinalizerTest reverted to real test case - added missing class variables to DigitalSigntureAlgorithm - Fix issue #13: TraitsTests pollutes ProtoObject subclasses (Mantis 7090) - make BitmapStreamTest clean up the file bitmapStreamTest.ref.extSeg I pushed everything into the Pharo repository, updated ScriptLoader (update10042), and moved the relevant packages from PharoInbox to PharoTreatedInbox. Cheer, Adrian On Jun 18, 2008, at 22:47 , Stéphane Ducasse wrote:
Hi norbert
did you read the answer of nicolas on squeak-dev on your question. I read the mantis entry he mentioned but i read superficially. :)
Stef
On Jun 18, 2008, at 9:40 PM, Norbert Hartl wrote:
On Wed, 2008-06-18 at 21:37 +0200, Adrian Lienhard wrote:
Hi Norbert,
We do this kind of scripts in the ScriptLoader. Just let me know when you published your slice and I will prepare the ScriptLoader update script which Stef can then push into the update stream.
I published the slice 1 minute before sending the mail :)
Have fun,
Norbert
Adrian
On Jun 18, 2008, at 19:30 , Norbert Hartl wrote:
So,
now I'm all for fixing it and ressurect the test case. I'll upload something to PharoInbox. Afterwards it needs to be reinitialized. What is the preferred way of having doits in the update stream?
Anyway I uploaded SLICE-WeakRegistryAndFinalizerTestFix to PharoInbox.
afterwards a
WeakRegistry default initialize: WeakRegistry default size
will be necessary.
Norbert
From: Andreas Raab <andreas.raab@gmx.de> Date: June 18, 2008 7:02:11 PM GMT+02:00 To: The general-purpose Squeak developers list <squeak-dev@lists.squeakfoundation.org
Subject: [squeak-dev] Re: Bug in object finalization? Reply-To: The general-purpose Squeak developers list <squeak-dev@lists.squeakfoundation.org
Norbert Hartl wrote:
On Wed, 2008-06-18 at 09:22 -0700, Andreas Raab wrote:
Norbert Hartl wrote:
There was a test in 3.9 testing this (it failed). In 3.10 the test got removed but I think it is a bug.
What do you think? The test itself is buggy (see http://bugs.squeak.org/view.php?id=6347) but once you fix the test it illustrates a problem in WeakRegistry which needs to use a WeakIdentityKeyDictionary instead of a WeakKeyDictionary.
Ok, what I said. Do you see an harmful side effects by exchanging the dictionary?
No - we've fixed this a long time ago in our code base.
Cheers, - Andreas
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project
_______________________________________________ Pharo-project mailing list Pharo-project@lists.gforge.inria.fr http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/pharo-project