Will do so after a thorough test/ recheck on code by next weekend.. On Mon, Feb 13, 2012 at 1:59 AM, Stéphane Ducasse <stephane.ducasse@inria.fr
wrote:
Thanks
What I suggest is produce some change set with the proposed fixes you have. Morphic was written before new invoked initialize automatically and to of places would benefit from that. Benjamin and alain helped already a lot to improve the situation.
Stef
On Feb 12, 2012, at 8:59 PM, S Krish wrote:
* CheckboxMorph does not implement #defaultBounds or take sensible
defaults.
* PluggableTextFieldMorph defaults to defaulBounds of MorphicModel,
does not hideScrollBars.. both h and v.. ?, in effect is not defaulted to behave like a single line TextFieldMorph.
* PluggableTextMorph has #defaultBounds of MorphicModel.. prefer a
better bounds of a standard text morpsh typically flatter of 400@300 .. ?. Unless immediately initiated with #on:text:readSelection:menu, we need explicitly handling. I would suggest if we can look at initializing for the morph
PluggableTextMorph>>initialize
... self setText: ''. textMorph bounds: self defaultBounds. self acceptOnFocusChange: true. ... * SystemWindow >> openInWorld: aWorld .. self bounds: (RealEstateAgent initialFrameFor: self world: aWorld). ...
bounds should not be hardcoded.. to full extents. Use a more sensible flexible approach in all framework classes.
This perhaps a neat comment..!
openAsIsIn: aWorld "Sad fixup for dodgy layout."
super openAsIsIn: aWorld. self allMorphs do: [:m | m layoutChanged]
* In Pharo 1.3 I do not have OBTextMorphSelection >> #debugIt
*